Skip to content

Commit

Permalink
stop hardcoding 1-target in alertmanagerrule
Browse files Browse the repository at this point in the history
  • Loading branch information
fourstepper committed Oct 1, 2024
1 parent 55c7d2a commit 739c82c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/helpers/prometheus_helper.go
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ func (mrs *MonitoringRuleSet) SetupRules() ([]monitoringv1.RuleGroup, error) {
if mrs.Slo.ObjectMeta.Annotations["osko.dev/magicAlerting"] == "true" {
duration := monitoringv1.Duration("5m")
var alertRules []monitoringv1.Rule
alertRules = append(alertRules, mrs.createMagicMultiBurnRateAlert(alertRuleErrorBudgets, "0.001", &duration, config.Cfg.AlertSeverities.HighFast))
alertRules = append(alertRules, mrs.createMagicMultiBurnRateAlert(alertRuleErrorBudgets, fmt.Sprintf("1-%s", mrs.Slo.Spec.Objectives[0].Target), &duration, config.Cfg.AlertSeverities.HighFast))
ruleGroups = append(ruleGroups, monitoringv1.RuleGroup{
Name: fmt.Sprintf("%s_slo_alert", sloName), Rules: alertRules,
})
Expand Down

0 comments on commit 739c82c

Please sign in to comment.