Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Fix #111 #112

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Fix #111 #112

merged 1 commit into from
Jan 9, 2021

Conversation

matburnham
Copy link
Contributor

@matburnham matburnham commented Jul 28, 2020

Fixes #111 to build with Node 12 and Node 14.

@matburnham matburnham marked this pull request as ready for review July 30, 2020 00:10
@matburnham
Copy link
Contributor Author

Notwithstanding #114 this seems to pass all tests and works with the code I was originally trying to use with Node 12. Travis-CI passes except for Node 4 which was already broken.

@awendt
Copy link

awendt commented Dec 14, 2020

@springmeyer @joto Can we please get this merged?

Also, will you accept a pull request that removes unsupported NodeJS versions? (i.e. v4, v6, and v8)

@springmeyer
Copy link
Contributor

@awendt I'm no longer in a position where I have time to do releases or test them. This one in particular might get the code to compile but it would require testing to ensure it runs correctly. Also, the right solution here is to port to NAPI, but that is a big effort. So, I must ask, would you or @matburnham be able to accomplish what you are trying to do with osmium-tool instead of node-osmium?

@awendt
Copy link

awendt commented Dec 15, 2020

@springmeyer Thanks for the heads-up!

I have been using node-osmium for a script that checks the Haversine distance for each way and drops the ones that are shorter than a threshold. From the docs, I don't see how this can be easily replaced with osmium-tool but I'm sure I can find a way.

@joto joto merged commit 0caddb6 into osmcode:master Jan 9, 2021
@joto
Copy link
Member

joto commented Jan 9, 2021

Thanks for the PR. I am sorry it took so long to get it merged. Unfortunately node-osmium is at the bottom of my priority list and it always takes me some time to come around to it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Won't build on node 12
4 participants