Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check denom of SpendLimit #292

Merged
merged 3 commits into from
Jul 21, 2022
Merged

fix: check denom of SpendLimit #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f240cb7
check denom of SpendLimit
czarcas7ic Jul 20, 2022
9d543a6
Update operations.go
czarcas7ic Jul 20, 2022
0e654eb
bump up gas
czarcas7ic Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion simapp/helpers/test_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@ import (
)

// SimAppChainID hardcoded chainID for simulation
// TODO: Implement a tool to check for gas growth. For now,
// we must increase this across the board for longer runs to work
const (
DefaultGenTxGas = 1000000
DefaultGenTxGas = 2000000
SimAppChainID = "simulation-app"
)

Expand Down
2 changes: 1 addition & 1 deletion x/authz/simulation/operations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ func SimulateMsgExec(ak authz.AccountKeeper, bk authz.BankKeeper, k keeper.Keepe
return simtypes.NoOpMsg(authz.ModuleName, TypeMsgExec, "not a send authorization"), nil, nil
}

if sendAuth.SpendLimit.IsAllLTE(coins) {
if !sendAuth.SpendLimit.IsAllGTE(coins) || !coins.DenomsSubsetOf(sendAuth.SpendLimit) {
return simtypes.NoOpMsg(authz.ModuleName, TypeMsgExec, "over spend limit"), nil, nil
}

Expand Down