forked from cosmos/iavl
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast Cache - Downgrade - reupgrade protection and other improvements #12
Merged
+1,300
−976
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
6350dc8
add leaf hash to fast node and unit test
p0mvn 5f579c5
refactor get with index and get by index, fix migration in load versi…
p0mvn f6ebabb
use Get in GetVersioned of mutable tree
p0mvn 89633f7
refactor non membership proof to use fast storage if available
p0mvn 75d9f81
bench non-membership proof
p0mvn 19ee7d3
fix bench tests to work with the new changes
p0mvn cbf2f41
add downgrade-reupgrade protection and unit test
p0mvn 96208dc
remove leaf hash from fast node
p0mvn 5217e71
resolve multithreading bug related to iterators not being closed
p0mvn ea072a6
clean up
p0mvn 806b1a0
use correct tree in bench tests
p0mvn 3f24e71
add cache to tree used to bench non membership proofs
p0mvn 0cb480e
add benc tests for GetWithIndex and GetByIndex
p0mvn ee1ab84
revert GetWithIndex and GetByIndex
p0mvn 2edb8cc
remove unused import
p0mvn 9712e87
unit test re-upgrade protection and fix small issues
p0mvn eea8cfd
remove redundant setStorageVersion method
p0mvn cd0a61c
fix bug with appending to live stage version to storage version and n…
p0mvn 8586d10
add comment for setFastStorageVersionToBatch
p0mvn c293938
refactor and improve unit tests for reupgrade protection
p0mvn eae9425
rename ndb's isFastStorageEnabled to hasUpgradedToFastStorage and add…
p0mvn 2241204
comment out new implementation for GetNonMembershipProof
p0mvn 31710b3
update comments in nodedb to reflect the difference between hasUpgrad…
p0mvn c0e4776
refactor nodedb tests
p0mvn 51b6c2f
downgrade tendermint to 0.34.14 - osmosis's latest cosmos sdk does no…
p0mvn a7e7fb2
fix bug where fast storage was not enabled when version 0 was attempt…
p0mvn f78896b
implement unsaved fast iterator to be used in mutable tree (#16)
p0mvn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor non membership proof to use fast storage if available
commit 89633f7e8352517162774d0fccb3d9361a7480a8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrmm, isn't iterating over all of fast node state going to be slower than a logarithmic number of file opens? Is there a way we can set a 'smarter' start bound?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can do this speedup in a non-db breaking way later, so may also be worth commenting out its invocation in
GetNonMembershipProof
and revisiting after we get the initial release out!