[Sumtree]: Lazy Static Max/Min Spot #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on order direction
There was a problem hiding this comment.
I know I was the one who added the TODO, but how confident do we feel in using lazy_static here from a security standpoint? Based on some other uses of it (e.g. svix/svix-webhooks#1024), it seems it hasn't been maintained in a while and we might have better native options in Rust now
Also generally not sure how this functionality plays with CW contracts so unless we're confident it's safe it might be better to err on the side of caution and not do it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
These changes are to clear an outstanding
TODOcomment, replacingmin_spot_priceandmax_spot_pricewith lazy statically evaluated constantsMIN_SPOT_PRICEandMAX_SPOT_PRICE.Testing and Verifying
No tests were altered as a result of this