Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some breaking changes, see opral/monorepo#290. No further breaking changes are expected for the foreseeable future.
I also looked at finding a method to let users add new languages. Difficult. The day js files (https://github.com/osmosis-labs/osmosis-frontend/blob/master/packages/web/localizations/dayjs-locale-en.js) can not be generated via the editor. Adding new languages via the editor could creating new resources (
de.json
) etc. but the maintainers would still need to manually create the dayjs files + in the user store settings:osmosis-frontend/packages/web/stores/user-settings/language.tsx
Line 12 in e478fd9
Ideally, an i18n library (see opral/monorepo#289 (comment)) would deal with both problems automatically.