Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove streamswap module #3133

Closed
p0mvn opened this issue Oct 24, 2022 · 3 comments · Fixed by #3146
Closed

chore: remove streamswap module #3133

p0mvn opened this issue Oct 24, 2022 · 3 comments · Fixed by #3146
Assignees
@hieuvubk
Labels
Good first issue T:code-hygiene

Comments

@p0mvn
Copy link
Member

p0mvn commented Oct 24, 2022

Background

According to latest product updates, streamswap is to be implemented in CosmWasm.

Therefore, we should remove the existing module.

Acceptance Criteria

  • delete contents of x/streamswap
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Oct 24, 2022
@hieuvubk
Copy link
Contributor

Is anyone working on this issue, we would like to close it. @ThanhNhann

@p0mvn
Copy link
Member Author

p0mvn commented Oct 25, 2022 via email

@hieuvubk hieuvubk self-assigned this Oct 25, 2022
@hieuvubk
Copy link
Contributor

@p0mvn Should we remove proto files if don't use them

@hieuvubk hieuvubk mentioned this issue Oct 25, 2022
Merged
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hieuvubk hieuvubk

Labels
Good first issue T:code-hygiene
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove streamswap osmosis-labs/osmosis
2 participants
@p0mvn @hieuvubk