Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VS Incentives]: CreateGroup review and test updates #6505

Closed
Tracked by #6057
p0mvn opened this issue Sep 23, 2023 · 0 comments · Fixed by #6529
Closed
Tracked by #6057

[VS Incentives]: CreateGroup review and test updates #6505

p0mvn opened this issue Sep 23, 2023 · 0 comments · Fixed by #6529
Assignees
@p0mvn
Labels
F: volume-splitting feat: Volume-splitting incentives

Comments

@p0mvn
Copy link
Member

p0mvn commented Sep 23, 2023 •
edited
Loading

Context

CreateGroup was initially implemented and lated refactor multiple times:

Once all of the above are complete, we need to do a final pass on the method and make sure that it is sufficiently tested and satisfies the desired invariants

A/C

  • CreateGroup reviewed
  • Test coverage maximized
  • CreateGroup refactored and cleaned up if needed
  • Tests refactored and cleaned up if needed
  • Ensure fee is charged for group creation
  • Ensure subdao can bypass fee
@p0mvn p0mvn mentioned this issue Sep 23, 2023
Closed
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Sep 23, 2023
@p0mvn p0mvn changed the title [VS Incentives]: CreateGroup review and test update [VS Incentives]: CreateGroup review and test updates Sep 23, 2023
@p0mvn p0mvn added the F: volume-splitting feat: Volume-splitting incentives label Sep 23, 2023
@p0mvn p0mvn self-assigned this Sep 24, 2023
This was referenced Sep 24, 2023
Merged
Merged
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
F: volume-splitting feat: Volume-splitting incentives
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[VS Incentives]: feat: group creation fee osmosis-labs/osmosis
1 participant
@p0mvn