-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VS Incentives]: feat: group creation fee #6529
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
changed the title
feat: group creation fee
[VS Incentives]: feat: group creation fee
Sep 25, 2023
p0mvn
force-pushed
the
roman/group-creation-fee
branch
from
September 25, 2023 12:41
626c5c5
to
fa750ca
Compare
p0mvn
commented
Sep 25, 2023
p0mvn
commented
Sep 25, 2023
czarcas7ic
approved these changes
Sep 26, 2023
Co-authored-by: Adam Tucker <[email protected]>
pysel
pushed a commit
that referenced
this pull request
Sep 27, 2023
* [Volume Splitting] feat: implement initGaugeInfo helper * comments * refactor/test: CreateGroup takes pool IDs; new tests * lint * [VS Incentives]: feat: group creation fee * comment updates * fixes issues * Update x/incentives/keeper/gauge_test.go Co-authored-by: Adam Tucker <[email protected]> --------- Co-authored-by: Adam Tucker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:no-changelog
C:app-wiring
Changes to the app folder
C:x/incentives
V:state/breaking
State machine breaking PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6505
What is the purpose of the change
Adding fee for group creation and tests
Testing and Verifying
Updated
TestCreateGauge
Documentation and Release Note
Unreleased
section ofCHANGELOG.md
?Where is the change documented?
x/{module}/README.md
)