Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VS Incentives]: feat: group creation fee #6529

Merged
merged 9 commits into from
Sep 26, 2023
Merged

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Sep 25, 2023

Closes: #6505

What is the purpose of the change

Adding fee for group creation and tests

Testing and Verifying

Updated TestCreateGauge

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@github-actions github-actions bot added C:x/incentives C:app-wiring Changes to the app folder labels Sep 25, 2023
@p0mvn p0mvn changed the title feat: group creation fee [VS Incentives]: feat: group creation fee Sep 25, 2023
@p0mvn p0mvn added V:state/breaking State machine breaking PR A:no-changelog labels Sep 25, 2023
@p0mvn p0mvn force-pushed the roman/group-creation-fee branch from 626c5c5 to fa750ca Compare September 25, 2023 12:41
@p0mvn p0mvn marked this pull request as ready for review September 25, 2023 13:08
x/incentives/keeper/gauge.go Outdated Show resolved Hide resolved
Base automatically changed from roman/create-group-pool-ids to main September 26, 2023 13:54
@p0mvn p0mvn requested a review from czarcas7ic as a code owner September 26, 2023 13:54
proto/osmosis/incentives/params.proto Show resolved Hide resolved
x/incentives/keeper/gauge_test.go Outdated Show resolved Hide resolved
@p0mvn p0mvn merged commit 5e755b6 into main Sep 26, 2023
@p0mvn p0mvn deleted the roman/group-creation-fee branch September 26, 2023 21:31
pysel pushed a commit that referenced this pull request Sep 27, 2023
* [Volume Splitting] feat: implement initGaugeInfo helper

* comments

* refactor/test: CreateGroup takes pool IDs; new tests

* lint

* [VS Incentives]: feat: group creation fee

* comment updates

* fixes issues

* Update x/incentives/keeper/gauge_test.go

Co-authored-by: Adam Tucker <[email protected]>

---------

Co-authored-by: Adam Tucker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:no-changelog C:app-wiring Changes to the app folder C:x/incentives V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VS Incentives]: CreateGroup review and test updates
2 participants