Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(release): Automated post-upgrade tasks by code generating upgrade handler and auto-increasing e2e version #3054

Closed
wants to merge 58 commits into from
Closed

feat(release): Automated post-upgrade tasks by code generating upgrade handler and auto-increasing e2e version #3054

wants to merge 58 commits into from

Conversation

pysel
Copy link
Member

@pysel pysel commented Oct 19, 2022

Closes: #2609

Brief Changelog

On release creation will be triggered GitHub action which will make a pull request with added new file for new version in app/upgrades and increase E2E_UPGRADE_VERSION in Makefile

pysel#8 Here is a pull request from a fork which shows what exactly this action does

I am not sure if this should be documented or not, so making it draft for now. What do you think @p0mvn?

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? no

@pysel
Copy link
Member Author

pysel commented Oct 19, 2022

Also very important I have not yet checked tests for e2e 1) if they all pass 2) they test the new upgrade handler

p0mvn
p0mvn approved these changes Oct 20, 2022
View reviewed changes
.github/workflows/auto-update-upgrade.yml
@@ -0,0 +1,27 @@
name: On Release Auto Upgrade
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Can you please add docs/comments directly in this file explaining what this CI job does? Excited to try it next upgrade!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes absolutely will!

p0mvn
p0mvn reviewed Oct 20, 2022
View reviewed changes
scripts/empty_upgrade_handler_gen.sh
@@ -0,0 +1,40 @@
#!/bin/bash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also add comments here about what this file is and link it to the CI job file (.yml)

@p0mvn
Copy link
Member

p0mvn commented Oct 20, 2022

Also very important I have not yet checked tests for e2e 1) if they all pass 2) they test the new upgrade handler

I think this would be great to check

@pysel
Copy link
Member Author

pysel commented Oct 20, 2022

@p0mvn docs added but please do not merge it yet I am not sure everything is good with e2e stuff, gotta check it tomorrow

@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Oct 22, 2022
This was referenced Oct 22, 2022
Closed
Merged
@p0mvn
Copy link
Member

p0mvn commented Oct 24, 2022

You seem to have another more up to date PR related to this: #3100

Can we close this one?

@pysel
Copy link
Member Author

pysel commented Oct 24, 2022

You seem to have another more up to date PR related to this: #3100

Can we close this one?

yes, this one Is just to check e2e tests in CI

@pysel pysel closed this Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0mvn p0mvn p0mvn approved these changes

Assignees
No one assigned
Labels
C:app-wiring Changes to the app folder T:build T:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(release): automate post-upgrade tasks by code generating upgrade handler and auto-increasing e2e version
2 participants
@pysel @p0mvn