Upgrade handler code-gen #4031
Merged
Upgrade handler code-gen #4031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Master pi 2124/upgrade handler
…124/osmosis into MasterPi-2124/upgrade-handler # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Master pi 2124/upgrade handler
update before merge
Close Osmosis issues
|
@p0mvn can you take a look into that? Thankyou <3 |
p0mvn
reviewed
Jan 18, 2023
| run: bash ./scripts/empty_upgrade_handler_gen.sh ${{ env.input }} | ||
|
|
||
| - name: Create PR | ||
| if: env.MAJOR == 1 | ||
| uses: peter-evans/create-pull-request@v4 | ||
| with: | ||
| base: ${{ github.event.repository.default_branch }} | ||
| token: ${{ secrets.COMMIT_TO_BRANCH }} |
There was a problem hiding this comment.
Ahh it seems to me that we need this for the similar reasons to the import paths action:
p0mvn
added
the
V:state/compatible/no_backport
p0mvn
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3632 and #3628
What is the purpose of the change
Testing and Verifying
I created a pr on notional-labs/osmosis, which can be seen here https://github.com/notional-labs/osmosis/pull/96