Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dupplication in SwapAmountInRoute #4039

Merged
merged 22 commits into from
Jan 18, 2023
Merged

Remove dupplication in SwapAmountInRoute #4039

merged 22 commits into from
Jan 18, 2023

Conversation

phamminh0811
Copy link
Contributor

Closes: #3921

What is the purpose of the change

This PR remove SwapAmountInRoute implementations from gamm module

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

MasterPi-2124 and others added 16 commits December 21, 2022 02:59
…124/osmosis into MasterPi-2124/upgrade-handler # Please enter a commit message to explain why this merge is necessary, # especially if

it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Jan 17, 2023
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

@mattverse mattverse added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label Jan 17, 2023
x/gamm/types/route_test.go Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the T:CI label Jan 18, 2023
@github-actions github-actions bot removed the T:build label Jan 18, 2023
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet thanks

@p0mvn p0mvn merged commit 49dd541 into osmosis-labs:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/gamm Changes, features and bugs related to the gamm module. V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SwapRouter] misc: Delete duplication of SwapAmountInRoute between gamm module and swap router module
4 participants