-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dupplication in SwapAmountInRoute #4039
Merged
p0mvn
merged 22 commits into
osmosis-labs:main
from
notional-labs:minh/remove-duplication
Jan 18, 2023
Merged
Remove dupplication in SwapAmountInRoute #4039
p0mvn
merged 22 commits into
osmosis-labs:main
from
notional-labs:minh/remove-duplication
Jan 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Master pi 2124/upgrade handler
…124/osmosis into MasterPi-2124/upgrade-handler # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Master pi 2124/upgrade handler
update before merge
Close Osmosis issues
github-actions
bot
added
the
C:x/gamm
Changes, features and bugs related to the gamm module.
label
Jan 17, 2023
mattverse
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
mattverse
added
the
V:state/compatible/no_backport
State machine compatible PR, depends on prior breaks
label
Jan 17, 2023
p0mvn
reviewed
Jan 17, 2023
p0mvn
reviewed
Jan 18, 2023
p0mvn
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:x/gamm
Changes, features and bugs related to the gamm module.
V:state/compatible/no_backport
State machine compatible PR, depends on prior breaks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3921
What is the purpose of the change
This PR remove SwapAmountInRoute implementations from gamm module
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? (yes / no)x/<module>/spec/
) / Osmosis docs repo / not documented)