Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct sample json exit-fee field value for stableswap pool creation on CLI command description #5860

Conversation

magiodev
Copy link
Contributor

What is the purpose of the change

This pull request corrects the sample json returned by the create-pool cli command for stableswap pool creation. Exit-fee field value is 0.01 while Stableswap pool type cannot be created with a non-zero exit fee.

Testing and Verifying

This change is already covered by existing tests. This PR doesn't change any logical part.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@github-actions github-actions bot added C:CLI C:x/gamm Changes, features and bugs related to the gamm module. labels Jul 17, 2023
@p0mvn p0mvn added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks A:no-changelog V:state/compatible/backport State machine compatible PR, should be backported A:backport/v16.x backport patches to v16.x branch and removed V:state/compatible/no_backport State machine compatible PR, depends on prior breaks labels Jul 17, 2023
@ValarDragon ValarDragon merged commit 85489fb into osmosis-labs:main Jul 28, 2023
mergify bot pushed a commit that referenced this pull request Jul 28, 2023
ValarDragon pushed a commit that referenced this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v16.x backport patches to v16.x branch A:no-changelog C:CLI C:x/gamm Changes, features and bugs related to the gamm module. V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants