Make generated proto files be committed from CI #5982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
added
V:state/compatible/backport
ValarDragon
requested review from
mattverse,
stackman27 and
AlpinYukseloglu
as code owners
ValarDragon
changed the title
|
devbot merge base |
|
devbot merge base (First call was too soon, necessary pr wasn't into main) |
p0mvn
pushed a commit
that referenced
this pull request
Aug 29, 2023
* Try committing result * fix indent * fix cmd * try-token * Tryfix * try again * Try again * try docs suggested method * try simpler thing * ah wrong perms at top * try agian * Try actions/checkout#317 * try actions/checkout#719 * Generated protofile changes * Try again * Generated protofile changes * use proper paths filtering * Make it do make proto-all * Rename workflow, add go.sum to diff list --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: devbot-wizard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes generated proto files be committed from CI.
Also fixes oddities in the generation code job.