Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed mint and burn message examples to include the to and from addresses #6002

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

maxrobot
Copy link
Contributor

@maxrobot maxrobot commented Aug 9, 2023

What is the purpose of the change

Add a description of the overall background and high level changes that this PR introduces

Simply to add the mint-to-address and burn-from-address into the examples of the CLI for mint and burn tokenfactory messages.

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

Copy link
Member

@pysel pysel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@p0mvn p0mvn added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v16.x backport patches to v16.x branch A:no-changelog and removed A:no-changelog labels Aug 9, 2023
@p0mvn
Copy link
Member

p0mvn commented Aug 9, 2023

devbot add changelog fix tokenfactory CLI to include address parameters for mint and burn

@p0mvn
Copy link
Member

p0mvn commented Aug 9, 2023

devbot help

@devbot-wizard
Copy link
Collaborator

Hi! I'm DevBot, a bot that helps with common tasks in the development process. Commands:

  • devbot fix: Fix basic errors in the PR. (e.g. imports, changelog conflicts, go mod conflicts)
  • devbot merge base: Merge the base branch into the PR branch.
  • devbot add changelog [misc/feat/bug/api/sec] [message]: Add a changelog entry to the PR. (e.g. devbot add changelog feat Added a new feature)
    • If message is blank, defaults to PR title.
  • devbot re-pr: Re-PR the PR, useful for external contributors where we have no edit perms.

@p0mvn
Copy link
Member

p0mvn commented Aug 9, 2023

devbot add changelog bug fix tokenfactory CLI to include address parameters for mint and burn

@p0mvn
Copy link
Member

p0mvn commented Aug 9, 2023

@ValarDragon making you aware of a devbot issue^

@czarcas7ic
Copy link
Member

@ValarDragon devbot not working because its targeting osmosis-labs:main instead of main

@ValarDragon
Copy link
Member

ValarDragon commented Aug 9, 2023

You'd have to run re-PR it to make it work from a fork right now. We can try to make it work with forks where we have push rights.

This may be why check proto is also failing, we may need to have a different flow for forks and this repo for that

@ValarDragon ValarDragon merged commit af41714 into osmosis-labs:main Aug 9, 2023
mergify bot pushed a commit that referenced this pull request Aug 9, 2023
ValarDragon pushed a commit that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v16.x backport patches to v16.x branch C:CLI C:x/tokenfactory V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants