[VS Incentives] refactor/test: move group gauge creation to CreateGauge; address spam concerns #6536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
commented
Sep 25, 2023
| s.Require().NoError(err) | ||
| externalGauge, err := s.App.IncentivesKeeper.GetGaugeByID(s.Ctx, externalGaugeid) | ||
| s.Require().NoError(err) | ||
| externalGauge := s.createGaugeNoRestrictions(tc.isPerpertual, tc.gaugeCoins, tc.distrTo, tc.startTime, tc.numEpochsPaidOver, defaultCLPool) |
There was a problem hiding this comment.
Note: it was required to modify the test and create this helper due to stricter validation in CreateGauge. The goal is to setup an invalid gauge state so that Distribute() function below fails. With the old logic, it was impossible to hit edge cases while keeping stricter validation
p0mvn
commented
Sep 25, 2023
Comment on lines
-470
to
-491
| const ( | ||
| zeroPoolId = uint64(0) | ||
| balancerPoolId = uint64(1) | ||
| concentratedPoolId = uint64(2) | ||
| invalidPool = uint64(3) | ||
| // 3 are created for balancer pool and 1 for CL. | ||
| // As a result, the next gauge id should be 5. | ||
| defaultExpectedGaugeId = uint64(5) | ||
|
|
||
| defaultIsPerpetualParam = false | ||
|
|
||
| defaultNumEpochPaidOver = uint64(10) | ||
| ) | ||
|
|
||
| var ( | ||
| defaultCoins = sdk.NewCoins( | ||
| sdk.NewCoin("uosmo", osmomath.NewInt(100000)), | ||
| sdk.NewCoin("atom", osmomath.NewInt(99999)), | ||
| ) | ||
|
|
||
| defaultTime = time.Unix(0, 0) | ||
| ) |
There was a problem hiding this comment.
Note: moved up to share across tests and reduce duplication
p0mvn
commented
Sep 25, 2023
Comment on lines
-239
to
-242
| if numEpochPaidOver == 0 { | ||
| return 0, types.ErrZeroNumEpochsPaidOver | ||
| } |
There was a problem hiding this comment.
Note: perpetual gauges are signified by numEpochPaidOver of 0
…ge; address spam concerns
p0mvn
force-pushed
the
roman/move-group-gauge-create
branch
from
d25ea9f to
4c795aa
Compare
czarcas7ic
approved these changes
Sep 26, 2023
Comment on lines
+1037
to
+1044
| func (s KeeperTestSuite) validateNoGaugeIDInSlice(slice []types.Gauge, gaugeID uint64) { | ||
| gaugeMatch := osmoutils.Filter(func(gauge types.Gauge) bool { | ||
| return gauge.Id == gaugeID | ||
| }, slice) | ||
| // No gauge matched ID. | ||
| s.Require().Empty(gaugeMatch) | ||
|
|
||
| } |
There was a problem hiding this comment.
Can ignore but this feels like we could maybe abstract this helper as a whole to osmoutils
There was a problem hiding this comment.
Probably not osmoutils because this depends on apptesting.Suite. I will move this to apptesting though, good idea!
Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
pysel
pushed a commit
that referenced
this pull request
Sep 27, 2023
…ge; address spam concerns (#6536) * [Volume Splitting] feat: implement initGaugeInfo helper * comments * refactor/test: CreateGroup takes pool IDs; new tests * lint * [VS Incentives]: feat: group creation fee * comment updates * fixes issues * [VS Incentives] refactor/test: move group gauge creation to CreateGauge; address spam concerns * Update x/incentives/keeper/gauge_test.go Co-authored-by: Adam Tucker <[email protected]> * Update x/incentives/keeper/gauge_test.go Co-authored-by: Adam Tucker <[email protected]> --------- Co-authored-by: Adam Tucker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6513, #6491
What is the purpose of the change
This PR focuses low-level and repetitive group gauge creation logic in
CreateGroupand, instead, moves that underCreateGauge.This also addresses the spam concern in #6491 since
CreateGaugealready handles that.This PR also added stricter checks for the input validation to
CreateGaugeTesting and Verifying
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)