Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ibc-hooks (and its tests) #6752

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Fix ibc-hooks (and its tests) #6752

merged 3 commits into from
Oct 24, 2023

Conversation

nicolaslara
Copy link
Contributor

Closes: #6739

What is the purpose of the change

Fix the ibc-hooks tests

Testing and Verifying

all ibc hooks tests should pass

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@github-actions
Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

@czarcas7ic czarcas7ic merged commit 8a3c5ce into chore/update-to-v0.47.x Oct 24, 2023
@czarcas7ic czarcas7ic deleted the nicolas/unfork-tests branch October 24, 2023 15:21
czarcas7ic added a commit that referenced this pull request Nov 9, 2023
@PaddyMc @czarcas7ic
@nicolaslara @mattverse
feat: upgrade sdk to v0.47.x (#6413)
5494ad8 
* chore: update all deps to v0.47.5

* chore: remove most references to outdated simapp functions

* chore: remove rest endpoints

* chore: swap simapp.FundAccount to bank.testutil.FundAccount for modules

* chore: remove wasm client and go.mod replace for grpc

* chore: fix osmoutils imports

* chore: fix ibc-hooks imports

* chore: final fixes to compile

* chore: skd.StoreKey changed storetypes.StoreKey in tokenfactory

* update gomods

* large push unfork work (mainly modules)

* more changes

* add SimAppChainID

* more fixes

* push before flight

* get it to compile

* temp local replace

* update go mods

* changelog

* update all gomods

* Revert "update all gomods"

This reverts commit 32f7f99.

* dont use simapp

* remove simapp

* more go mod fixes

* more go mod changes, disable go work

* change unforktodo to unforkingtodo

* fix ibc unforking todos

* set sequence from -1 to 0

* further get through unforking comments, add secondary label

* address more comments

* fix further lints

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* attempt to fix go mod

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* cometbft to 37.2 instead of 38

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* go mod tidy

* address comments

* unforkingtodo to unforkingnote

* remove invalid FastSync config

* unforking notes for simulator

* change upgrade code to unforkingnote

* simulation section of upgrading

* import runtime.AppI interface

* remove reference to beta3

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* beta2

* v20

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* math bump

* require it, idk why it keeps switching

* replace gogo with cosmos gogoproto imports

* update osmov20

* remove old proto

* Revert "remove old proto"

This reverts commit c8857bd.

* Revert "update osmov20"

This reverts commit c212bea.

* Revert "remove old proto"

This reverts commit c8857bd.

* Revert "replace gogo with cosmos gogoproto imports"

This reverts commit 8b7fe47.

* initial attempt at changing to cosmos proto

* local replaces for v20

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* manual removal of gogo so we can remove from go mod

* fix wiring

* test fixes

* more test fixes

* more test fixes

* tests

* fix e2e init

* fixes

* script

* wasmbindings fixes

* fix mint

* comment out test

* Fix superfluid & tokenfactory

* chore: fix x/epochs tests

* chore: fix x/ibc-rate-limit tests

* Fix ibc-hooks (and its tests) (#6752)

* initial unfork test changes

* fix bad marshalling

* remove wasmd override

* change gas test

* fix upgrade test

* disable simulator

* network

* cli

* remove local replaces

* add proto replace

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* add genesis block antehandle logic

* protobuf

* go mods

* go mod

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* wave of fixes highlighted from e2e

* proto changes

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* remove gogo/protobuf manually

* manual remove gogo from everything

* mod

* regen replace

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* proto gen

* script debug ci

* test

* test

* test

* update buf

* update script

* create dir

* specify output

* test

* test

* downgrade proto builder

* test

* test

* chmod

* buf version

* debug

* test

* Generated protofile changes

* FINALLY

* revert

* revert 14 to 13.1

* oops

* upgrade version

* lints

* lints

* add nolints

* more lints

* more lints

* more lints

* add temp fix

* possibly revert, remove exclude for beta3

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* Revert "Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally"

This reverts commit 9c671b1.

* Revert "possibly revert, remove exclude for beta3"

This reverts commit f7c4377.

* add fee grant

* remove install buf step

* fixes

* default message validator for genutil

* add chain-id to test

* reset chain id

* ibcfeekeeper, upgrade store remove, chainid

* init ibc fee keeper

* use rate limit instead of fee keeper

* crisis to store upgrade

* move to v21 upgrade handler

* implement POB

* finish upgrade handler

* small changes from review

* passby review

* e2e

* attempt block time over heights

* change x exp go mod version

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* exp ver

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* replace line for exp

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* use v1.4.10 instead of v1.4.11

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* use newest osmosis version of cosmos sdk v47

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* reduce flakiness for e2e with new sdk logic

* more e2e tweaking

* change fork branch to neater branch

* downgrade cosmossdk math

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* drop down osmomath versions

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* sdk math down

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* makefile change

* math bump down

* add exclude

* set gov to v2

* Generated protofile changes

* e2e flakiness

* slight extension to vote period e2e

* debugging

* add more e2e err logs

* logs

* potentially revert go mod changes

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* Revert "Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally"

This reverts commit c942be4.

* Revert "potentially revert go mod changes"

This reverts commit d3f3eaf.

* run tidy

* enable everything in go work

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* switch v20

* exclusions

* fix make build

* block sdk in place of pob

* modify pob

* remove group, fee, and nft

* comment out

* upgrade math package

* go mod

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* go mod updates

* implement expedited props

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* remove redundant flags

* Auto: update go.mod after push to chore/update-to-v0.47.x that modified dependencies locally

* expedited prop

* lint

---------

Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: Nicolas Lara <[email protected]>
Co-authored-by: github-actions <[email protected]>
Co-authored-by: mattverse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@PaddyMc PaddyMc PaddyMc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolaslara @PaddyMc @czarcas7ic