Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SuperfluidDelegationsByValidatorDenom does not return equivalent staked amount #7857

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Mar 27, 2024

Closes: #7842

What is the purpose of the change

Fixes query to return equivalent staked amount.

Testing and Verifying

Tested against mainnet and got values instead of null

Summary by CodeRabbit

  • New Features
    • Enhanced the SuperfluidDelegationsByValidatorDenom query to return the equivalent staked amount, improving clarity and usability for end-users.

@czarcas7ic czarcas7ic added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v23.x backport patches to v23.x branch A:backport/v24.x backport patches to v24.x branch labels Mar 27, 2024
@czarcas7ic czarcas7ic marked this pull request as ready for review March 27, 2024 03:12
Copy link
Contributor

coderabbitai bot commented Mar 27, 2024

Walkthrough

This update introduces a crucial enhancement to the SuperfluidDelegationsByValidatorDenom query in the Osmosis blockchain, specifically addressing a bug where the equivalent staked amount of OSMO for CL pools Superfluid staked was returning null. The changes refine the calculation and handling of equivalentAmount within superfluid delegation queries, ensuring that the equivalent staked OSMO amount is accurately represented, thereby enabling better tracking and display on dashboards.

Changes

File Path Change Summary
x/superfluid/keeper/grpc_query.go Adjusted equivalentAmount calculation and error handling in SuperfluidDelegationsByDelegator and SuperfluidDelegationsByValidatorDenom.

Assessment against linked issues

Objective Addressed Explanation
Fix the bug where the equivalent staked amount returns null for CL pools Superfluid staked on dashboards. (#7842)

Poem

In the realm of Osmosis, where liquidity flows,
A rabbit hopped in, tweaking the code it knows.
"No more nulls," it declared, with a swift code spree,
For CL pools' stakes, now as clear as can be.
🐰💻🌊
Through the blockchain burrows, the fix was spread wide,
Now dashboards gleam, with data verified.
"To bugs and confusion, we bid thee farewell!"
The rabbit cheered, as the validators tell.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Collaborator

@PaddyMc PaddyMc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!!

@czarcas7ic czarcas7ic merged commit f3ff198 into main Mar 27, 2024
1 check passed
@czarcas7ic czarcas7ic deleted the adam/fix-SuperfluidDelegationsByValidatorDenom branch March 27, 2024 16:03
mergify bot pushed a commit that referenced this pull request Mar 27, 2024
… staked amount (#7857)

* fix SuperfluidDelegationsByValidatorDenom query

* add changelog

(cherry picked from commit f3ff198)

# Conflicts:
#	CHANGELOG.md
mergify bot pushed a commit that referenced this pull request Mar 27, 2024
… staked amount (#7857)

* fix SuperfluidDelegationsByValidatorDenom query

* add changelog

(cherry picked from commit f3ff198)

# Conflicts:
#	CHANGELOG.md
mergify bot pushed a commit that referenced this pull request Mar 27, 2024
… staked amount (#7857)

* fix SuperfluidDelegationsByValidatorDenom query

* add changelog

(cherry picked from commit f3ff198)
czarcas7ic added a commit that referenced this pull request Mar 27, 2024
… staked amount (#7857) (#7869)

* fix SuperfluidDelegationsByValidatorDenom query

* add changelog

(cherry picked from commit f3ff198)

Co-authored-by: Adam Tucker <[email protected]>
czarcas7ic added a commit that referenced this pull request Mar 27, 2024
… staked amount (backport #7857) (#7867)

* fix: SuperfluidDelegationsByValidatorDenom does not return equivalent staked amount (#7857)

* fix SuperfluidDelegationsByValidatorDenom query

* add changelog

(cherry picked from commit f3ff198)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Adam Tucker <[email protected]>
czarcas7ic added a commit that referenced this pull request Mar 27, 2024
… staked amount (backport #7857) (#7868)

* fix: SuperfluidDelegationsByValidatorDenom does not return equivalent staked amount (#7857)

* fix SuperfluidDelegationsByValidatorDenom query

* add changelog

(cherry picked from commit f3ff198)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Adam Tucker <[email protected]>
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v23.x backport patches to v23.x branch A:backport/v24.x backport patches to v24.x branch C:x/superfluid V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Query for CL pools Superfluid equivalent staked returns null
3 participants