Remove duplicated one minus spread factor calculations (backport #8040) #8066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 670efe0)
mergify
bot
requested review from
czarcas7ic,
p0mvn and
AlpinYukseloglu
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicated one minus spread factor calculations.
Since there are only a small number of spread factors, we may consider just putting this in RAM eventually. In a subsequent (state breaking PR) I also want to cache
spreadfactor / (1 - spreadfactor)and use that directly in computations.I'm interested in feedback if this is worth the code complexity. This PR: cosmos/cosmos-sdk#20034 will also help speedup the quo logic in this code. (It will 50% reduce the QuoRoundUpMut time seen in prod)
Summary by CodeRabbit
This is an automatic backport of pull request #8040 done by [Mergify](https://mergify.com).