chore: set optimistic execution #8393
Conversation
WalkthroughThe update enhances the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 golangci-lint (1.62.2)level=warning msg="The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar." 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (3)cmd/osmosisd/cmd/root.go (1)
The addition of CHANGELOG.md (2)Line range hint The changelog properly follows the Keep a Changelog format with:
The changelog entries correctly document:
Both changes are appropriately categorized under "State Compatible" since they don't introduce state-breaking changes. Let's verify the state compatibility claim: ✅ Verification successfulBased on the search results, I can now provide a final response: Enabling optimistic execution is a state-compatible change The change to enable optimistic execution (#8393) is correctly categorized under the "State Compatible" section in the changelog, not under "State Breaking". This is supported by:
The changelog categorization is accurate and no further verification is needed. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify that the changes don't modify any state-related code
# Check for any state store modifications in the PR
rg -A 5 "KVStore|MemStore|store.Set|store.Delete"
# Check for any proto changes that could affect state
rg -A 5 "^message\s|^enum\s" "*.proto"
Length of output: 113752 Script: #!/bin/bash
# Check for any state-breaking changes in the PR
# Look for changes in proto files that could affect state
fd -e proto -x cat {} \;
# Look for any state-breaking changes in the changelog
rg -A 5 "State Breaking" CHANGELOG.md
# Look for any optimistic execution related changes
rg -A 5 "optimistic.*execution"
Length of output: 112584 Script: #!/bin/bash
# Look for optimistic execution related changes in the codebase
rg -A 5 "optimistic.*execution" .
# Look for any state-breaking changes in the PR
rg -A 5 "State Breaking" .
# Check for any changes in consensus parameters or state-related code
rg -A 5 "consensus|state" CHANGELOG.md
Length of output: 16187 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Actually since this is state compat, maybe we should get v26.0.0 without this, and v26.1.0 with it? |
|
@ValarDragon I was told by Facu from Binary Builders that the feat does nothing without 2/3 voting power on it. We can add in minor but I don't think there is a high likelyhood of getting voting power on it without a manual push |
|
Lets keep this open until v26.0.0 is out and then merge, as per Dev's request. |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
czarcas7ic
added
V:state/compatible/no_backport
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
you should be able to test this on mainnet today allowing you to track performance |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
* set optimistic execution * changelog --------- Co-authored-by: PaddyMc <[email protected]> (cherry picked from commit 2d06f20)
* set optimistic execution * changelog --------- Co-authored-by: PaddyMc <[email protected]> (cherry picked from commit 2d06f20) Co-authored-by: Adam Tucker <[email protected]>
Closes: #XXX
What is the purpose of the change
As requested by @ValarDragon