Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cosmos-sdk v0.50.11 #8906

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

PaddyMc
Copy link
Collaborator

@PaddyMc PaddyMc commented Dec 20, 2024

Closes: #XXX

What is the purpose of the change

  • bump the cosmos sdk v0.50.11

Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

@PaddyMc PaddyMc added A:backport/v28.x backport patches to v28.x branch V:state/compatible/backport State machine compatible PR, should be backported labels Dec 20, 2024
Copy link
Contributor

coderabbitai bot commented Dec 20, 2024

Walkthrough

This pull request updates the CHANGELOG.md file with new version entries for v28.0.1 and v28.0.0. The changes include adding chore entries for bumping the cosmos-sdk version, updating the math package, and fixing an incorrect channel in the XCS module. The changelog maintains its structured format, documenting notable changes across different versions with appropriate tags and issue references.

Changes

File Change Summary
CHANGELOG.md - Added ## v28.0.1 with cosmos-sdk version bump chore entry
- Added ## v28.0.0 with math package update chore entry
- Updated ## v27.0.1 with XCS incorrect channel fix

Possibly related PRs

Suggested labels

A:backport/v26.x

Suggested reviewers

  • czarcas7ic
  • nicolaslara
  • ValarDragon

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
CHANGELOG.md (2)

50-51: Version number format inconsistency

The version number format switches between different styles (e.g. "v28.0.1" vs "v28.0.0"). Consider standardizing the format across all version entries.


Line range hint 1-100: Add release dates to version entries

Consider adding dates to each version entry to help track when changes were released. This is recommended by the Keep a Changelog format.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc358f6 and 7aae284.

⛔ Files ignored due to path filters (10)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum, !**/*.sum
  • osmomath/go.mod is excluded by !**/*.mod
  • osmomath/go.sum is excluded by !**/*.sum, !**/*.sum
  • osmoutils/go.mod is excluded by !**/*.mod
  • osmoutils/go.sum is excluded by !**/*.sum, !**/*.sum
  • x/epochs/go.mod is excluded by !**/*.mod
  • x/epochs/go.sum is excluded by !**/*.sum, !**/*.sum
  • x/ibc-hooks/go.mod is excluded by !**/*.mod
  • x/ibc-hooks/go.sum is excluded by !**/*.sum, !**/*.sum
📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
🔇 Additional comments (1)
CHANGELOG.md (1)

Line range hint 1-1000: LGTM on changelog structure and content

The changelog follows good practices:

  • Changes are properly categorized (State Breaking, Features, Bug Fixes etc.)
  • Each change links to its PR
  • Clear descriptions of changes
  • Breaking changes are highlighted
  • Upgrade instructions are linked where relevant

Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@PaddyMc PaddyMc closed this Dec 22, 2024
@PaddyMc PaddyMc reopened this Dec 22, 2024
@PaddyMc PaddyMc merged commit 334a8cd into main Dec 22, 2024
1 check passed
@PaddyMc PaddyMc deleted the chore/bump-cosmos-sdk-v0.50.11-v28-osmo-1 branch December 22, 2024 11:59
mergify bot pushed a commit that referenced this pull request Dec 22, 2024
* chore: bump cosmos-sdk v0.50.11

* chore: update CHANGELOG.md

(cherry picked from commit 334a8cd)

# Conflicts:
#	CHANGELOG.md
#	x/ibc-hooks/go.mod
#	x/ibc-hooks/go.sum
PaddyMc added a commit that referenced this pull request Jan 7, 2025
* chore: bump cosmos-sdk v0.50.11 (#8906)

* chore: bump cosmos-sdk v0.50.11

* chore: update CHANGELOG.md

(cherry picked from commit 334a8cd)

# Conflicts:
#	CHANGELOG.md
#	x/ibc-hooks/go.mod
#	x/ibc-hooks/go.sum

* chore: fix merge conflict

* chore: update changelog.md

---------

Co-authored-by: PaddyMc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v28.x backport patches to v28.x branch C:x/epochs V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants