check for errors return status from extension table.

osquery · Dec 9, 2019 · 5590218 · 5590218
1 parent 7922cd7
commit 5590218
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/osquery/sql/virtual_table.cpp b/osquery/sql/virtual_table.cpp
@@ -1003,7 +1003,14 @@ static int xFilter(sqlite3_vtab_cursor* pVtabCursor,
     PluginRequest request = {{"action", "generate"}};
     TablePlugin::setRequestFromContext(context, request);
     QueryData qd;
-    Registry::call("table", pVtab->content->name, request, qd);
+    auto status =
+        Registry::call("table", pVtab->content->name, request, qd);
+    if (!status.ok()) {
+      VLOG(1) << "Invalid response from the extension table. Error "
+              << status.getCode() << ": " << status.getMessage();
+      setTableErrorMessage(pVtabCursor->pVtab, status.getMessage());
+      return SQLITE_ERROR;
+    }
     pCur->rows = tableRowsFromQueryData(std::move(qd));
   }