-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Windows) New table: connectivity #5500
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI failure looks like an unrelated hang. Anything else I can do here? |
cc @theopolis or @alessandrogario for a review here -- should be good to go, apart from the unrelated macOS CI failures. |
Will do shortly, and heads up, the macOS failures should be fixed on master. |
theopolis
requested changes
Oct 2, 2019
We've addressed the CI failure. If you don't mind rebasing onto master, this should fix the issue. |
Looks like this was actually fixed in the headers at some point.
theopolis
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla signed
Automated label: Pull Request author has signed the osquery CLA
networking
ready for review
Pull requests that are ready to be reviewed by a maintainer
Windows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
connectivity
table, which contains the current system-wide (i.e., all interface) network state:Each column corresponds to an
NLM_CONNECTIVITY
flag: https://docs.microsoft.com/en-us/windows/desktop/api/netlistmgr/ne-netlistmgr-nlm_connectivity