Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Windows) New table: connectivity #5500

Merged
merged 15 commits into from Oct 4, 2019
Merged

(Windows) New table: connectivity #5500

merged 15 commits into from Oct 4, 2019

Conversation

woodruffw
Copy link
Contributor

Introduces the connectivity table, which contains the current system-wide (i.e., all interface) network state:

osquery> select * from connectivity;
+--------------+-----------------+-----------------+-------------+--------------------+---------------+-------------+--------------------+---------------+
| disconnected | ipv4_no_traffic | ipv6_no_traffic | ipv4_subnet | ipv4_local_network | ipv4_internet | ipv6_subnet | ipv6_local_network | ipv6_internet |
+--------------+-----------------+-----------------+-------------+--------------------+---------------+-------------+--------------------+---------------+
| 0            | 0               | 1               | 0           | 0                  | 1             | 0           | 0                  | 0             |
+--------------+-----------------+-----------------+-------------+--------------------+---------------+-------------+--------------------+---------------+

Each column corresponds to an NLM_CONNECTIVITY flag: https://docs.microsoft.com/en-us/windows/desktop/api/netlistmgr/ne-netlistmgr-nlm_connectivity

@facebook-github-bot facebook-github-bot added the cla signed Automated label: Pull Request author has signed the osquery CLA label Mar 6, 2019
@woodruffw
Copy link
Contributor Author

CI failure looks like an unrelated hang.

Anything else I can do here?

@woodruffw woodruffw changed the base branch from experimental to master September 27, 2019 20:25
@woodruffw
Copy link
Contributor Author

cc @theopolis or @alessandrogario for a review here -- should be good to go, apart from the unrelated macOS CI failures.

@theopolis
Copy link
Member

Will do shortly, and heads up, the macOS failures should be fixed on master.

@mike-myers-tob mike-myers-tob added Windows ready for review Pull requests that are ready to be reviewed by a maintainer networking labels Oct 2, 2019
@theopolis
Copy link
Member

We've addressed the CI failure. If you don't mind rebasing onto master, this should fix the issue.

@theopolis theopolis merged commit 06dd05c into osquery:master Oct 4, 2019
@woodruffw woodruffw deleted the william/feature/windows_connectivity branch October 4, 2019 19:52
muffins pushed a commit to muffins/osquery that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Automated label: Pull Request author has signed the osquery CLA networking ready for review Pull requests that are ready to be reviewed by a maintainer Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants