Fix #5737: Add FileVersionRaw column to file table for windows #5771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the file_version column to the file table for windows. I have used the approach of adding a new parameter to the windowsGetFileVersion(). I have refactored the name of the method as well as the parameters. Here is a blueprint of the same:
/*
*/
Status windowsGetVersionInfo(const std::string& path, std::string& product_version, std::string& file_version);
I have added the additional field for the fileVersion in the row structure as well as have placed a validation test in the file table.
Tackling issue: #5737