feature 6401: authenticode table with catalog file info #6677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theopolis
reviewed
Sep 28, 2020
theopolis
reviewed
Sep 28, 2020
| @@ -125,6 +126,49 @@ void generateRow(Row& row, const SignatureInformation& signature_info) { | |||
| } | |||
| } | |||
|
|
|||
| bool getCatalogPathForFilePath(const std::wstring path, | |||
There was a problem hiding this comment.
I think this should be passed by const reference too.
There was a problem hiding this comment.
Sure, updated. Compiler will optimize these cases. Modern compilers have made me lazy. :)
theopolis
approved these changes
Oct 1, 2020
|
Thanks a ton! |
|
Sure thing. For some reason, I didn't receive notification for your first comment. To answer that specific question: If you query for notepad.exe, you'll now see the catalog signature information. For example, |
aikuchin
pushed a commit
to aikuchin/osquery
that referenced
this pull request
Jul 11, 2023
…1 to master * commit 'dc2c7d0ef21f7913448c664ae0ebddd034afc977': (43 commits) Changelog 4.5.1 (osquery#6692) Fix incorrect stat return checking within process_events (osquery#6694) tests: Reduce flakiness of test_osqueryi (osquery#6688) Flush stdout with --help (osquery#6693) Enable cppcheck target in macOS builds (osquery#6685) Fix dirPathsAreEqual the documented way (osquery#6690) Add broad exception catching for table execution (osquery#6689) Authenticode table with catalog file info (osquery#6677) Document max interval for scheduled queries (osquery#6683) Fix container overflow in curl_certificate (osquery#6664) Update documentation around build steps (osquery#6681) Incorporate suggested changes on PR 5789 from Directionless Copy-edit and Markdown lint the remaining deployment docs Copy-edit and Markdown lint, clarify section headers for HTTP API doc Copy-edit and Markdown lint, remove old comment about CI Copy-edit and Markdown lint many deployment docs Fixed handling of invalid array bound error with EvtNext function (osquery#6660) Copy-edit and Markdown lint (just nits) remaining developer docs Copy-edit and Markdown lint (just nits) several developer docs Copy-edit and Markdown lint the configuration plugin guidance; minor clarification ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #6401. Authenticode table will now show signature information for files, which themselves are not signed, but whose hashes are in a signed system catalog file.