Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew no longer allows ~ in version strings #2390

Closed
scpeters opened this issue Sep 6, 2023 · 1 comment
Closed

brew no longer allows ~ in version strings #2390

scpeters opened this issue Sep 6, 2023 · 1 comment
Labels

Comments

@scpeters
Copy link
Member

scpeters commented Sep 6, 2023

I noticed brew audit failures in #2389:

osrf/simulation/[email protected]
    * Stable: version 6.10.0~20211005~d2b6ee08a60d0dbf71b0f008cd8fed1f611f6e24 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  osrf/simulation/gz-fuel-tools9
    * Stable: version 9.0.0~pre1 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  osrf/simulation/gz-gui8
    * Stable: version 8.0.0~pre1 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  osrf/simulation/gz-harmonic
    * Stable: version 1.0.0~pre2 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  osrf/simulation/gz-launch7
    * Stable: version 7.0.0~pre1 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  osrf/simulation/gz-msgs10
    * Stable: version 10.0.0~pre3 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  osrf/simulation/gz-physics7
    * Stable: version 7.0.0~pre2 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  osrf/simulation/gz-rendering8
    * Stable: version 8.0.0~pre1 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  osrf/simulation/gz-sensors8
    * Stable: version 8.0.0~pre1 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  osrf/simulation/gz-sim8
    * Stable: version 8.0.0~pre1 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  osrf/simulation/gz-transport13
    * Stable: version 13.0.0~pre1 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  osrf/simulation/ogre2.1
    * Stable: version 2.0.99999~pre0~0~[20](https://github.com/osrf/homebrew-simulation/actions/runs/6090415938/job/16525198188?pr=2389#step:9:21)180616~06a386f does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  osrf/simulation/ogre2.2
    * Stable: version 2.2.6+20[21](https://github.com/osrf/homebrew-simulation/actions/runs/6090415938/job/16525198188?pr=2389#step:9:22)1021~312bf40 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  osrf/simulation/sdformat14
    * Stable: version 14.0.0~pre2 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  Error: Stable: version 6.10.0~20211005~d2b6ee08a60d0dbf71b0f008cd8fed1f611f6e[24](https://github.com/osrf/homebrew-simulation/actions/runs/6090415938/job/16525198188?pr=2389#step:9:25) does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,1[27](https://github.com/osrf/homebrew-simulation/actions/runs/6090415938/job/16525198188?pr=2389#step:9:28)}$
  Error: Stable: version 9.0.0~pre1 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  Error: Stable: version 8.0.0~pre1 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  Error: Stable: version 1.0.0~pre2 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  Error: Stable: version 7.0.0~pre1 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  Error: Stable: version 10.0.0~pre3 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  Error: Stable: version 7.0.0~pre2 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  Error: Stable: version 8.0.0~pre1 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  Error: Stable: version 8.0.0~pre1 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  Error: Stable: version 8.0.0~pre1 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  Error: Stable: version 13.0.0~pre1 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  Error: Stable: version 2.0.99999~pre0~0~20180616~06a386f does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  Error: Stable: version 2.2.6+20211021~[31](https://github.com/osrf/homebrew-simulation/actions/runs/6090415938/job/16525198188?pr=2389#step:9:32)2bf[40](https://github.com/osrf/homebrew-simulation/actions/runs/6090415938/job/16525198188?pr=2389#step:9:41) does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  Error: Stable: version 14.0.0~pre2 does not match ^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$
  Error: 14 problems in 14 formulae detected.

I believe this is caused by a policy change in brew audit in Homebrew/brew#15936 that doesn't like our use of ~ characters in prerelease version strings. I'll see if it works to change them to - instead.

@scpeters
Copy link
Member Author

scpeters commented Sep 6, 2023

this audit has been relaxed in Homebrew/brew#15972

closing

@scpeters scpeters closed this as completed Sep 6, 2023
scpeters added a commit to gazebo-tooling/release-tools that referenced this issue Oct 10, 2023
Replace the `~` separator characters with `-` in
homebrew formula version strings to satisfy
osrf/homebrew-simulation#2390.

Signed-off-by: Steve Peters <[email protected]>
azeey pushed a commit to gazebo-tooling/release-tools that referenced this issue Oct 10, 2023
Replace the `~` separator characters with `-` in
homebrew formula version strings to satisfy
osrf/homebrew-simulation#2390.

Signed-off-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant