Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdformat12: build main branch from source #1459

Merged
merged 3 commits into from
May 14, 2021

Conversation

scpeters
Copy link
Member

This is a potential approach for solving #1314, motivated by gazebosim/gz-sim#811, which has failing CI since the sdformat12 formula is outdated.

@scpeters scpeters requested a review from chapulina May 14, 2021 00:52
@chapulina
Copy link
Contributor

Trying it out here, I think:

Build Status

I assume this doesn't need a bottle build, right?

@chapulina
Copy link
Contributor

Humm that didn't work

+ brew pull https://github.com/osrf/homebrew-simulation/pull/1459
Error: Unknown command: pull

I'm not sure how to test this 🤔

@scpeters
Copy link
Member Author

Humm that didn't work

+ brew pull https://github.com/osrf/homebrew-simulation/pull/1459
Error: Unknown command: pull

I'm not sure how to test this 🤔

yeah, we can't test this in CI anymore. they disabled the brew pull command. we need to test it manually

@scpeters
Copy link
Member Author

I've tested it manually. we can also try a binary approach:

build bottle

@scpeters
Copy link
Member Author

I've tested it manually

to clarify, it fixed gazebosim/gz-sim#811 in my manual testing

@chapulina
Copy link
Contributor

Cool, I see the bottle has been uploaded! Merging!

@chapulina chapulina merged commit 6229716 into osrf:master May 14, 2021
@scpeters scpeters deleted the sdf12_from_source branch May 20, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants