Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python bindings so PYTHONPATH isn't needed #2036

Merged
merged 9 commits into from
Sep 7, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Sep 4, 2022

This installs the python bindings for gz-math7 and sdformat13 to lib/python3.10 instead of lib/python and explicitly depends on the [email protected] formula. This should allow our bindings to be used with home-brew's [email protected] without setting PYTHONPATH.

@scpeters scpeters requested a review from azeey September 4, 2022 05:55
@scpeters
Copy link
Member Author

scpeters commented Sep 4, 2022

build bottle

Signed-off-by: Steve Peters <[email protected]>
@scpeters
Copy link
Member Author

scpeters commented Sep 4, 2022

build bottle

@scpeters
Copy link
Member Author

scpeters commented Sep 4, 2022

brew audit failed:

osrf/simulation/gz-math7:
  * python modules have explicit framework links
    These python extension modules were linked directly to a Python
    framework binary. They should be linked with -undefined dynamic_lookup
    instead of -lpython or -framework Python.
      /usr/local/opt/gz-math7/lib/python3.10/site-packages/gz/math.cpython-310-darwin.so
      /usr/local/opt/gz-math7/lib/python3.10/site-packages/ignition/math.cpython-310-darwin.so

@scpeters
Copy link
Member Author

scpeters commented Sep 6, 2022

trying again with patch from gazebosim/gz-math#497

build bottle

@scpeters
Copy link
Member Author

scpeters commented Sep 6, 2022

build bottle

Copy link
Member

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@scpeters scpeters merged commit 971ea50 into master Sep 7, 2022
@scpeters scpeters deleted the scpeters/python_install branch September 7, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants