-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new ros3djs with CBOR PointCloud2 #12
Conversation
Via a fork of polymer-ros-rviz.
@mvollrath , mind keeping a list of all upstream PRs that need to be merged so this change can be reverted? The list can either stay on this PR or in a new issue in this repository. |
|
Added links to relevant PRs on the list. |
Moved the list to #13 so we can merge this and keep working. |
Just for the record, I tested the pointclouds and it seems to work well with the new Some observations:
|
bower.json
Outdated
@@ -15,7 +15,7 @@ | |||
"tests" | |||
], | |||
"dependencies": { | |||
"ros-rviz": "osrf/polymer-ros-rviz#master", | |||
"ros-rviz": "EndPointCorp/polymer-ros-rviz#9c4061476657724fa8900a1ee973748e3781035d", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For easy reference, here's the difference between the current and the proposed dependencies:
osrf/polymer-ros-rviz@master...EndPointCorp:9c4061476657724fa8900a1ee973748e3781035d
In summary, it needs changes on:
Updated this PR to use the proposed ros3djs 1.0.0 with THREE r89 branch. PointCloud2 show/hide is broken, due to a ros3djs interface change. |
Now that all the dependencies and upgrades are already merged in ros-rviz, ros-websocket and ros-service, we can just keep pointing to master. Thanks @mvollrath! |
Point to a chain of forks that results in latest roslibjs and ros3djs. Since this chain of forks is not ideal, we should work to get all of the affected packages released and bowers updated: