Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move list of debian dependencies to packages.apt #392

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Move list of debian dependencies to packages.apt #392

merged 1 commit into from
Oct 21, 2020

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Oct 16, 2020 •
edited
Loading

This will help keeping the list of dependencies in a single place, which is easier to maintain. Being close to the source code also makes it simple to update when a PR introduces a new dependency.

Our Jenkins CI can start referring to this list instead of dependencies_archive.sh (see gazebo-tooling/release-tools#317) and other tools, like the API doc uploader can also make use of it.

The pattern we've been using is:

  • packages.apt for dependencies common to all platforms
  • packages-<distro>.apt for dependencies specific to Ubuntu

@chapulina chapulina requested a review from scpeters October 16, 2020 16:53
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 16, 2020
@chapulina chapulina mentioned this pull request Oct 16, 2020
Merged
@codecov-io
Copy link

codecov-io commented Oct 16, 2020 •
edited
Loading

Codecov Report

Merging #392 into sdf9 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             sdf9     #392   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files          59       59           
  Lines        9181     9181           
=======================================
  Hits         7919     7919           
  Misses       1262     1262

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6094b9d...7a07a71. Read the comment docs.

@scpeters
Copy link
Member

apparently including the string packages.apt in the branch name broke our jenkins script

sort -u ./sdformat/.github/ci/packages.apt ./sdformat/.git/refs/remotes/origin/chapulina/9/packages.apt ./sdformat/.git/logs/refs/remotes/origin/chapulina/9/packages.apt

@chapulina
Copy link
Contributor Author

apparently including the string packages.apt in the branch name broke our jenkins script

Yeah I noticed it here 🙃 That's why I did find .github instead.

I need to think of a better workaround, because the actions CI relies on finding dependencies of several packages in a workspace, on different folders.

scpeters added a commit to gazebo-tooling/release-tools that referenced this pull request Oct 17, 2020
@scpeters
Exclude */.git/* files when finding packages.apt
67d669e 
If a git branch name contains packages.apt, it can
break our jenkins script (see gazebosim/sdformat#392).

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters mentioned this pull request Oct 17, 2020
Merged
@scpeters
Copy link
Member

apparently including the string packages.apt in the branch name broke our jenkins script

Yeah I noticed it here 🙃 That's why I did find .github instead.

I need to think of a better workaround, because the actions CI relies on finding dependencies of several packages in a workspace, on different folders.

fix for release-tools: gazebo-tooling/release-tools#323

scpeters added a commit to gazebo-tooling/release-tools that referenced this pull request Oct 17, 2020
@scpeters
Exclude */.git/* files when finding packages.apt (#323)
9b1be47 
If a git branch name contains packages.apt, it can
break our jenkins script (see gazebosim/sdformat#392).

Signed-off-by: Steve Peters <[email protected]>
@scpeters
Copy link
Member

@osrf-jenkins run tests please

1 similar comment
@scpeters
Copy link
Member

@osrf-jenkins run tests please

@chapulina
Copy link
Contributor Author

CI is clear 🙌 Can we get this in?

@scpeters scpeters merged commit f9c31c9 into sdf9 Oct 21, 2020
@scpeters scpeters deleted the chapulina/9/packages.apt branch October 21, 2020 17:16
chapulina added a commit that referenced this pull request Oct 31, 2020
@chapulina
Move list of debian dependencies to packages.apt (#392)
cbb3352 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina mentioned this pull request Oct 31, 2020
Merged
chapulina added a commit that referenced this pull request Oct 31, 2020
@chapulina
Cherry-pick #392 to sdf10: Move list of debian dependencies to packag…
d4926b1 
…es.apt

Signed-off-by: Louise Poubel <[email protected]>
chapulina added a commit that referenced this pull request Oct 31, 2020
@chapulina
Cherry-pick #392 to master: Move list of debian dependencies to packa…
1eb6b9a 
…ges.apt

Signed-off-by: Louise Poubel <[email protected]>
chapulina added a commit that referenced this pull request Nov 2, 2020
@chapulina
Move list of debian dependencies to packages.apt (#392)
d619e0a 
Signed-off-by: Louise Poubel <[email protected]>
chapulina added a commit that referenced this pull request Nov 3, 2020
@chapulina
Cherry-pick #392 to master: Move list of debian dependencies to packa…
0093747 
…ges.apt

Signed-off-by: Louise Poubel <[email protected]>
chapulina added a commit that referenced this pull request Nov 3, 2020
@chapulina
Cherry-pick #392 to sdf10: Move list of debian dependencies to packag…
33bf356 
…es.apt

Signed-off-by: Louise Poubel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chapulina @codecov-io @scpeters