Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New config with thermal camera: MARBLE_HUSKY_SENSOR_CONFIG_3 and MARBLE_HUSKY_SENSOR_CONFIG_4 #779

Merged
merged 6 commits into from
Feb 11, 2021

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Feb 3, 2021

The thermal camera used for this model is the same as the one in #773. The only difference between the thermal camera for this model and the one in #773 should be the the camera's location.

sensor config 3 = sensor config 1 + thermal camera, and sensor config 4 = sensor config 2 + thermal camera

Here is where I have placed the thermal camera (right above the lower LIDAR sensor):
husky_thermal_camera

Signed-off-by: Ashton Larkin [email protected]

@adlarkin adlarkin requested review from nkoenig and iche033 February 3, 2021 17:15
@osrf-jenkins
Copy link

Build finished. 21 tests run, 0 skipped, 1 failed.

@iche033 iche033 changed the title Add thermal camera to marble husky New config with thermal camera: MARBLE_HUSKY_SENSOR_CONFIG_3: Feb 3, 2021
@iche033 iche033 changed the title New config with thermal camera: MARBLE_HUSKY_SENSOR_CONFIG_3: New config with thermal camera: MARBLE_HUSKY_SENSOR_CONFIG_3 Feb 3, 2021
@iche033 iche033 marked this pull request as draft February 3, 2021 19:29
@osrf-jenkins
Copy link

Build finished. 21 tests run, 0 skipped, 1 failed.

@osrf-jenkins
Copy link

Build finished. 21 tests run, 0 skipped, 1 failed.

@iche033 iche033 changed the title New config with thermal camera: MARBLE_HUSKY_SENSOR_CONFIG_3 New config with thermal camera: MARBLE_HUSKY_SENSOR_CONFIG_3 and MARBLE_HUSKY_SENSOR_CONFIG_4 Feb 3, 2021
@iche033 iche033 marked this pull request as ready for review February 3, 2021 20:53
@osrf-jenkins
Copy link

Build finished. 21 tests run, 0 skipped, 1 failed.

@adlarkin
Copy link
Contributor Author

adlarkin commented Feb 3, 2021

@iche033 I believe we should add this code snippet to the fuel model's model.sdf files in order to have the thermal camera placement as pictured above:

      <!-- thermal camera -->
      <visual name="thermal_camera_visual">
        <pose >0.485 0 0.169 0 0 0</pose>
        <geometry>
          <box>
            <size>0.02 0.025 0.025</size>
          </box>
        </geometry>
      </visual>
      <sensor name="thermal_camera" type="thermal">
        <pose >0.485 0 0.169 0 0 0</pose>
        <camera name="thermal_camera">
          <horizontal_fov>0.4922</horizontal_fov>
          <lens>
            <intrinsics>
              <!-- fx = fy = width / ( 2 * tan (hfov / 2 ) ) -->
              <fx>764.35630</fx>
              <fy>764.35630</fy>
              <!-- cx = ( width + 1 ) / 2 -->
              <cx>192.5</cx>
              <!-- cy = ( height + 1 ) / 2 -->
              <cy>144.5</cy>
              <s>0</s>
            </intrinsics>
          </lens>
          <image>
            <width>384</width>
            <height>288</height>
          </image>
          <clip>
            <near>0.1</near>
            <far>100</far>
          </clip>
        </camera>
        <always_on>1</always_on>
        <update_rate>25</update_rate>
      </sensor>

@osrf-jenkins
Copy link

Build finished. 21 tests run, 0 skipped, 1 failed.

@adlarkin
Copy link
Contributor Author

adlarkin commented Feb 3, 2021

@iche033 I just tested configurations 3 and 4. Everything seems to be working for me! I can echo data from the topics, and I can visualize the thermal camera in rviz.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me as well

@nkoenig
Copy link
Contributor

nkoenig commented Feb 10, 2021

Here is the latest output image stream from the thermal camera:

thermal

@nkoenig
Copy link
Contributor

nkoenig commented Feb 11, 2021

The Fuel models have been updated to use:

      <sensor name="thermal_camera" type="thermal">
        <pose>0.435 -.01 0.125 0 0 0</pose>
        <camera name="thermal_camera">
          <horizontal_fov>0.4922</horizontal_fov>
          <lens>
            <intrinsics>
              <!-- fx = fy = width / ( 2 * tan (hfov / 2 ) ) -->
              <fx>764.35630</fx>
              <fy>764.35630</fy>
              <!-- cx = ( width + 1 ) / 2 -->
              <cx>192.5</cx>
              <!-- cy = ( height + 1 ) / 2 -->
              <cy>144.5</cy>
              <s>0</s>
            </intrinsics>
          </lens>
          <image>
            <width>384</width>
            <height>288</height>
            <format>L8</format>
          </image>
          <clip>
            <near>0.1</near>
            <far>100</far>
          </clip>
        </camera>
        <always_on>1</always_on>
        <update_rate>25</update_rate>
        <plugin
          filename="ignition-gazebo-thermal-sensor-system"
          name="ignition::gazebo::systems::ThermalSensor">
          <min_temp>253.15</min_temp>
          <max_temp>673.15</max_temp>
        </plugin>
      </sensor>

@peci1
Copy link
Collaborator

peci1 commented Mar 15, 2021

The thermocam got lost from Fuel... #821.

@nkoenig nkoenig deleted the adlarkin/thermal_camera_marble_husky branch September 27, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants