Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wayfinding practice worlds #583

Merged
merged 10 commits into from
Apr 13, 2023
Merged

Wayfinding practice worlds #583

merged 10 commits into from
Apr 13, 2023

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Feb 7, 2023

Similar to #582 but for the wayfinding practice worlds.

How to test it?

Follow instructions from #582 but launch the worlds with:

ros2 launch vrx_gz competition.launch.py world:=practice_2022_wayfinding0_task
ros2 launch vrx_gz competition.launch.py world:=practice_2022_wayfinding1_task
ros2 launch vrx_gz competition.launch.py world:=practice_2022_wayfinding2_task

Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero requested a review from M1chaelM February 7, 2023 16:16
@caguero
Copy link
Contributor Author

caguero commented Mar 15, 2023

@M1chaelM , the environmental conditions have been updated. This PR is ready for review.

@M1chaelM
Copy link
Collaborator

M1chaelM commented Apr 7, 2023

@caguero It looks like the waypoint markers aren't enabled. To you want to merge #582 first?

@M1chaelM
Copy link
Collaborator

@caguero Looks like we are using exactly the same waypoints for worlds 0 and 2. I'm guessing this is a copy error?

Copy link
Collaborator

@M1chaelM M1chaelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost ready to go--can we use different waypoints for practice worlds 0 and 2?

Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Copy link
Contributor Author

caguero commented Apr 11, 2023

@caguero Looks like we are using exactly the same waypoints for worlds 0 and 2. I'm guessing this is a copy error?

Good catch, I just updated the waypoints of world 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants