Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore marker support #597

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Restore marker support #597

merged 1 commit into from
Feb 21, 2023

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Feb 20, 2023

Fixes #596.

This PR restores the support to overlay a 3D marker on the scene.

Known limitations:

  • Currently, it's not possible to render a TEXT marker. See this open issue.
  • It's not possible to pass a text material like in Gazebo classic (Gazebo/Red). Instead, it's possible to set ambient and diffuse values. I decided not to expose it as it seems that we're always using the same color for the markers. Let me know otherwise and we could expose it.

How to test it?

Launch one of the stationkeeping/wayfinding world and check that a white marker shows up. Example:

ros2 launch vrx_gz competition.launch.py world:=practice_2022_stationkeeping2_task

Screenshot from 2023-02-20 20-13-55

Signed-off-by: Carlos Agüero <[email protected]>
Copy link
Collaborator

@M1chaelM M1chaelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is great. The color definitely does not matter. The text was sometimes useful for debugging new course designs for wayfinding, but I think we can live without it.

@caguero caguero merged commit d3eb27a into caguero/practice_worlds Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants