Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Back Button and Hide Input Section After Dataset Upload #196 #200

Closed
wants to merge 1 commit into from

Conversation

Canada101
Copy link
Collaborator

@Canada101 Canada101 commented Oct 14, 2024

Fixes #196

What was changed?

I added the hiding of the input side bar upon entering a dataset and a back button that would appear after inputting data and make the sidebar reappear.

Why was it changed?

This was changed to make the ui flow better and give a more professional look and user experience.

How was it changed?

I added a label to the sidebar and a separate back action button that was not visible upon starting the program. this was done in the ui file. When the upload data button is clicked the sidebar gets hidden and the back button appears and when the back button is clicked this brings up the side bar. this was done by adding logic in the server file for when the buttons are clicked.

How was it tested

I tested this by running test files and ensuring you could see the back button and that when clicking it would bring back the sidebar.
backButtonCapstoneIssue.pdf

Screenshots that show the changes (if applicable):

@Canada101 Canada101 linked an issue Oct 14, 2024 that may be closed by this pull request
3 tasks
inputId = "backButton",
label = "Back",
style = "display: none;"
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! very clear and concise

observeEvent(input$backButton, {
shinyjs::show(id = "sidebar") # Show the sidebar content
shinyjs::hide(id = "backButton") # Hide the "Back" button
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, clear and concise

@kate-holdener
Copy link
Contributor

I think the "Back" button is confusing and doesn't resolve the issue of the application not being responsive (you can't upload another dataset). Also, once you use the "Back" button, there is no way to hide the left hand menu again. The "Back" button would make sense if it allowed us to get back to the menu and change parameters, but it doesn't allow us to change parameters.

Once the left hand menu disappears, the output looks strangely offset to the right, with a lot of blank space on the left.
Screenshot 2024-10-15 at 1 15 41 PM

Having the file upload menu disappear makes sense after the upload, I'm not sure if "Back" really makes sense. I've played with the application, and it feels awkward. Also, when switching the dropdown menu to show many entries (100), the back button ends up at the bottom and is hard to find.

@BollepalliPranitha @Canada101 I encourage you to carefully think through the design here to improve usability of the application.

@Massi-Papi
Copy link
Collaborator

I think the "Back" button is confusing and doesn't resolve the issue of the application not being responsive (you can't upload another dataset). Also, once you use the "Back" button, there is no way to hide the left hand menu again. The "Back" button would make sense if it allowed us to get back to the menu and change parameters, but it doesn't allow us to change parameters.

Once the left hand menu disappears, the output looks strangely offset to the right, with a lot of blank space on the left. Screenshot 2024-10-15 at 1 15 41 PM

Having the file upload menu disappear makes sense after the upload, I'm not sure if "Back" really makes sense. I've played with the application, and it feels awkward. Also, when switching the dropdown menu to show many entries (100), the back button ends up at the bottom and is hard to find.

@BollepalliPranitha @Canada101 I encourage you to carefully think through the design here to improve usability of the application.

I agree with this. Once you hit the "back" button, you can't really do anything. It just brings you back to the main page, and you aren't able to input anything new.
It also appears whenever you hit "Upload Data", and it is a bit of a nuisance on the screen. You should have the button hidden until everything loads. A good way to do that is with a boolean: False = Hidden, True = Showing
Especially with the reset data button that will incorporated later, this isn't necessary.

@BollepalliPranitha
Copy link
Collaborator

The primary goal of introducing the "Back" button was to enhance user experience by temporarily hiding the unresponsive input section after a dataset upload, allowing the user to focus on the full display of the data table. The idea was to provide a clear view of the uploaded data without distractions while ensuring users have an accessible way to return to the input form for resetting or updating the dataset if needed.
@Canada101
However, as noted, the current implementation does not fully address the issue regarding layout and responsiveness. The blank space on the left after the input section is hidden creates an imbalance in the interface, making the output look offset to the right.
The "Back" button currently appears whenever "Upload Data" is clicked, which is visible while the data is still loading. We should only show the "Back" button after the dataset has fully loaded to avoid unnecessary clutter.
We need to discuss and plan a more effective approach to incorporate these changes while ensuring a seamless user experience.

@BollepalliPranitha BollepalliPranitha self-requested a review November 5, 2024 22:41
Copy link
Collaborator

@BollepalliPranitha BollepalliPranitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation does not fully address the issue regarding layout and responsiveness. The blank space on the left after the input section is hidden creates an imbalance in the interface, making the output look offset to the right.

@BollepalliPranitha
Copy link
Collaborator

As this is not working as expected , and being a low priority issue, closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Back Button and Hide Input Section After Dataset Upload
5 participants