Ver 0.1 for PG12 or above

JOB/auto_tune_31c.sh

@@ -6,5 +6,5 @@ for i in `seq 1 17`; do
     echo "=== ${i} ===" && psql -f 31c_test.sql -P pager; 
 done
 
-psql -c "select id, pgsp_queryid, pgsp_planid, diff_of_joins, execution_time from plan_repo.plan_history order by id;"
+psql -c "select id, pgsp_queryid, pgsp_planid, join_rows_err, execution_time::numeric(8, 3) from plan_repo.plan_history order by id;"
 

Makefile

@@ -1,5 +1,5 @@
 EXTENSION = pg_plan_advsr
-DATA = pg_plan_advsr--0.0.sql 
+DATA = pg_plan_advsr--0.1.sql
 
 OBJS = pg_plan_advsr.o pgsp_json.o pgsp_json_text.o
 

TODO → TODO.md

@@ -18,5 +18,9 @@ Code
   pg_plan_advsr needs some files from pg_hint_plan and pg_store_plans.
   It would be better to copy them to its directory automaticaly.
 
-- Implement CREATE STATISTICS suggestion as a new feature
+- ~~Implement CREATE STATISTICS suggestion as a new feature~~
 
+- Improve Extended Statistics Suggestion feature
+	- Increase the number of supported column types: grouping columns and  expression columns
+	- Check existing Extended stats to prevent duplicate Extended stats suggestions
+	- Suggest only Extended stats that are effective

expected/base.out

@@ -106,8 +106,8 @@ on t1.c1 = t2.c1 and t1.c2 = t2.c2;
 (15 rows)
 
 -- Check the result of auto-tuning
-select rows_hint, diff_of_joins, lead_hint, join_hint, scan_hint, join_cnt from plan_repo.plan_history order by id desc limit 4;
-     rows_hint      | diff_of_joins |       lead_hint       |    join_hint     |              scan_hint              | join_cnt 
+select rows_hint, join_rows_err, lead_hint, join_hint, scan_hint, join_cnt from plan_repo.plan_history order by id desc limit 4;
+     rows_hint      | join_rows_err |       lead_hint       |    join_hint     |              scan_hint              | join_cnt 
 --------------------+---------------+-----------------------+------------------+-------------------------------------+----------
                     |             0 | LEADING( ((c a )b ) ) | HASHJOIN(a b c) +| SEQSCAN(c) SEQSCAN(a) SEQSCAN(b)    |        2
                     |               |                       | HASHJOIN(a c)    |                                     | 

expected/base_2.out

@@ -106,8 +106,8 @@ on t1.c1 = t2.c1 and t1.c2 = t2.c2;
 (15 rows)
 
 -- Check the result of auto-tuning
-select rows_hint, diff_of_joins, lead_hint, join_hint, scan_hint, join_cnt from plan_repo.plan_history order by id desc limit 4;
-     rows_hint      | diff_of_joins |       lead_hint       |    join_hint     |              scan_hint              | join_cnt 
+select rows_hint, join_rows_err, lead_hint, join_hint, scan_hint, join_cnt from plan_repo.plan_history order by id desc limit 4;
+     rows_hint      | join_rows_err |       lead_hint       |    join_hint     |              scan_hint              | join_cnt 
 --------------------+---------------+-----------------------+------------------+-------------------------------------+----------
                     |             0 | LEADING( ((c a )b ) ) | HASHJOIN(a b c) +| SEQSCAN(c) SEQSCAN(a) SEQSCAN(b)    |        2
                     |               |                       | HASHJOIN(a c)    |                                     | 

pg_plan_advsr--0.1.sql

@@ -0,0 +1,154 @@
+-- complain if script is sourced in psql, rather than via CREATE EXTENSION
+\echo Use "CREATE EXTENSION pg_plan_advsr" to load this file. \quit
+
+SET search_path = public;
+SET LOCAL client_min_messages = WARNING;
+
+CREATE SCHEMA plan_repo;
+
+-- Register tables
+CREATE TABLE plan_repo.plan_history
+(
+	id					serial,
+	norm_query_hash		text,
+	pgsp_queryid		bigint,
+	pgsp_planid			bigint,
+	execution_time		double precision,
+	rows_hint			text,
+	scan_hint			text,
+	join_hint			text,
+	lead_hint			text,
+	scan_rows_err		double precision,
+	scan_err_ratio		double precision,
+	join_rows_err		double precision,
+	join_err_ratio		double precision,
+	scan_cnt			int,
+	join_cnt			int,
+	application_name	text,
+	timestamp			timestamp
+);
+
+CREATE TABLE plan_repo.norm_queries
+(
+	norm_query_hash		text,
+	norm_query_string	text
+);
+
+CREATE TABLE plan_repo.raw_queries
+(
+	norm_query_hash		text,
+	raw_query_id		serial,
+	raw_query_string	text,
+	timestamp			timestamp
+);
+
+-- Register view
+CREATE VIEW plan_repo.plan_history_pretty
+AS
+SELECT id,
+	   norm_query_hash,
+	   pgsp_queryid,
+	   pgsp_planid,
+	   execution_time::numeric(18, 3),
+	   rows_hint,
+	   scan_hint,
+	   join_hint,
+	   lead_hint,
+	   scan_rows_err,
+	   scan_err_ratio::numeric(18, 2),
+	   join_rows_err,
+	   join_err_ratio::numeric(18, 2),
+	   scan_cnt,
+	   join_cnt,
+	   application_name,
+	   timestamp
+FROM plan_repo.plan_history
+ORDER BY id;
+
+-- Register functions
+CREATE FUNCTION pg_plan_advsr_enable_feedback()
+RETURNS void
+AS 'MODULE_PATHNAME'
+LANGUAGE C;
+
+CREATE FUNCTION pg_plan_advsr_disable_feedback()
+RETURNS void
+AS 'MODULE_PATHNAME'
+LANGUAGE C;
+
+CREATE OR REPLACE FUNCTION plan_repo.get_hint(bigint)
+RETURNS text
+	AS 'select ''/*+'' || chr(10) || '
+	   'lead_hint || chr(10) || '
+	   'join_hint || chr(10) || '
+	   'scan_hint || chr(10) || '
+	   '''*/'' || chr(10) || '
+	   '''--'' || pgsp_planid '
+	   'from plan_repo.plan_history '
+	   'where pgsp_planid = $1 '
+	   'order by id desc '
+	   'limit 1;'
+LANGUAGE SQL
+IMMUTABLE
+RETURNS NULL ON NULL INPUT;
+
+-- This function can use on PG14 or above with pg_qualstats
+CREATE OR REPLACE FUNCTION plan_repo.get_extstat(bigint)
+RETURNS TABLE (suggest text) AS $$
+	with all_quals as (
+		--左
+	    SELECT qualid,
+			   lrelid as rel,
+			   pg_catalog.quote_ident(n.nspname) || '.' ||
+			   pg_catalog.quote_ident(c.relname) as relname,
+			   pg_qualstats_get_idx_col(qualnodeid, true) as col
+	    FROM pg_qualstats() q
+	    JOIN pg_catalog.pg_class c ON q.lrelid = c.oid
+	    JOIN pg_catalog.pg_namespace n ON n.oid = c.relnamespace
+		WHERE queryid = $1
+		UNION
+		--右
+	    SELECT qualid,
+			   rrelid as rel,
+			   pg_catalog.quote_ident(n.nspname) || '.' ||
+			   pg_catalog.quote_ident(c.relname) as relname,
+			   pg_qualstats_get_idx_col(qualnodeid, true) as col
+	    FROM pg_qualstats() q
+	    JOIN pg_catalog.pg_class c ON q.rrelid = c.oid
+	    JOIN pg_catalog.pg_namespace n ON n.oid = c.relnamespace
+		WHERE queryid = $1
+	),
+	data as (
+		select relname,
+			   col
+		from all_quals
+		where col is not null
+		group by relname, col
+		ORDER BY 1, 2
+	),
+	rels_cols as (
+		select relname,
+			   array_to_string(array_agg(col), ', ') as cols,
+			   count(col) as col_num
+		from data
+		group by relname
+	),
+	nominated as (
+		select relname,
+			   cols
+		from rels_cols
+		where col_num > 1
+	)
+	select 'CREATE STATISTICS ON ' || array_to_string(array_agg(cols), ', ') || ' ' ||
+		   'FROM '|| relname || ';' as suggest
+	from nominated
+	group by relname
+	ORDER BY 1;
+$$ LANGUAGE sql;
+
+
+-- Grant
+GRANT SELECT ON plan_repo.plan_history TO PUBLIC;
+GRANT SELECT ON plan_repo.norm_queries TO PUBLIC;
+GRANT SELECT ON plan_repo.raw_queries TO PUBLIC;
+GRANT USAGE ON SCHEMA plan_repo TO PUBLIC;