[WIP] patch for discussion #174 #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although "log_directory" parameter's default value is changed in PostgreSQL version 10, pg_rman didn't change it. It leads following main issues if the "log_directory" is not specified. 1. Server logs are always backuped even if "--with-serverlog" is not specified because pg_rman fails to exclude the "PGDATA/log" directory from backup target lists. 2. pg_rman's "--keep-srvlog-files" and "--keep-srvlog-days" options are invalid because SRVLOG_PATH is wrong.
pg_rman supports to backup server logs with "--with-serverlog" option and backups them to the BACKUP_PATH directory. But, it didn't support to restore the backuped server logs. So, this patch supports to restore them from full backup and incremental backup.
|
Dear @mikecaat . Thank you for responding to this issue. Best regards. |
|
Dear @MoonInsung Thanks for researching! BTW, I think it's better to discuss this issue on the issue page, not on this page because some users may check only issue pages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the patch for #174 discussion. We need to discuss how to handle the issue.