Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '--recovery-target-action' option for restore(#182) #190

Merged

Conversation

mikecaat
Copy link
Contributor

Previously, users must execute 'pg_xlog_replay_resume()' or configure
'recovery_target_action' GUC parameter manually if the restored data
need archive recovery and users want to promote the server.

Since this limitation annoys users, this patch adds a new option
'--recovery-target-action'. If a user specifies this option when to
restore, pg_rman configures 'recovery_target_action' GUC parameter
automatically. So, the task which the user have to do is only to
start the server. After archive recovery is done, the server will
promote.

@mikecaat mikecaat force-pushed the add_recovery_target_action_option branch 2 times, most recently from b077d2f to 130c9b7 Compare June 24, 2021 02:46
@huangfumingyue
Copy link
Contributor

@mikecaat
Thank you for responding to this issue.
How about adding a description of pause | promote | shutdown to the manual?

@mikecaat
Copy link
Contributor Author

Thanks for your comments!
I didn't add the description because the manual has the following comments.

The parameters which are started with –recovery are same as parameters in recovery.conf. See also “Recovery Configuration” for details.

But, I changed my mind to write more detail is better as you said.

Previously, users must execute 'pg_xlog_replay_resume()' or configure
'recovery_target_action' GUC parameter manually if the restored data
need archive recovery and users want to promote the server.

Since this limitation annoys users, this patch adds a new option
'--recovery-target-action'. If a user specifies this option when to
restore, pg_rman configures 'recovery_target_action' GUC parameter
automatically. So, the task which the user have to do is only to
start the server. After archive recovery is done, the server will
promote.
@mikecaat mikecaat force-pushed the add_recovery_target_action_option branch from 130c9b7 to 911e4f5 Compare June 28, 2021 07:42
@mikecaat
Copy link
Contributor Author

I updated the patches. Please check it.

@huangfumingyue
Copy link
Contributor

Thanks!
It looks good to me.

@MoonInsung MoonInsung merged commit 17f7109 into ossc-db:master Jun 30, 2021
mikecaat pushed a commit to mikecaat/pg_rman that referenced this pull request Nov 16, 2022
The following commit(17f7109) forgot to change the index of
parameters although it adds a new parameter.

* Add '--recovery-target-action' option for restore(ossc-db#182) (ossc-db#190)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants