Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependabot doesn't update version string in comments to .yml files #427

Closed
maxfisher-g opened this issue Oct 27, 2022 · 1 comment · Fixed by #545
Closed

Dependabot doesn't update version string in comments to .yml files #427

maxfisher-g opened this issue Oct 27, 2022 · 1 comment · Fixed by #545
Assignees
@maxfisher-g
Labels
github actions Pull requests that update Github Actions

Comments

@maxfisher-g
Copy link
Contributor

When dependabot updates a dependency version in a github action ,yml files, it only changes the commit hash. This means that the version number in the inline comment becomes stale.

Can dependabot be configured to update the comment too?
@maxfisher-g maxfisher-g added enhancement New feature or request github actions Pull requests that update Github Actions labels Oct 27, 2022
@maxfisher-g
Copy link
Contributor Author

Seems to be implemented upstream: https://github.blog/changelog/2022-10-31-dependabot-now-updates-comments-in-github-actions-workflows-referencing-action-versions/

Relevant PR: dependabot/dependabot-core#5951

@maxfisher-g maxfisher-g removed the enhancement New feature or request label Dec 5, 2022
@maxfisher-g maxfisher-g self-assigned this Dec 5, 2022
@maxfisher-g maxfisher-g mentioned this issue Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxfisher-g maxfisher-g

Labels
github actions Pull requests that update Github Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update version comment for github action dependencies ossf/package-analysis
1 participant
@maxfisher-g