-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing Scorecard result viewer #2979
Comments
@tegioz This is AMAZING!!! Thank you!! @ossf/scorecard-maintainers 👀 |
I think the page looks great! If it's a static page, it could certainly be hosted on the Netlify portion of Scorecard's website. |
Thanks! And thank you for the feedback @evverx! We've just deployed some additional changes:
|
Now that I can sort the checks I think Anyway all I can say is that those dashboards are great. Thank you! I think badges should certainly point to them (once it's decided where they should officially live). |
In the scorecard default output we replace |
I think as long as they are grouped at the bottom "?" should do. It's certainly better than "n/a"'s scattered all over the place I was proposing here :-) It seems in dark mode selected areas aren't highlighted: dark-mode-selection.mov(on an absolutely unrelated note, I wonder what "CLO" stands for? My guess was that it's some level objectives but I can't seem to figure out what "C" is. Sorry for the off-topic. I'm just curious). |
Thanks, we'll take care of it soon 👍
It comes up every now and then, please see cncf/clomonitor#746 🙂 CLOTributor is another member of the CLO family 😉 |
Hi @evverx
In what OS are you experiencing this issue? We can't reproduce it in any browser in MacOS. We've also observed an alignment issue in the risk level badge in your video, so we'd like to take a look at that as well. |
I've just checked and as far as I can tell that laptop comes with macOS Big Sur 11.7.7. Newer laptops seem to be fine (or maybe the brightness settings aren't tweaked there :-)). Looks like it's some weird macOS-specific corner case affecting the dashboard dark mode with the default system dark mode. |
It's really weird. On YouTube it's dark. GitHub seems to get it around though. Anyway I'm not sure it needs fixing. I assume YouTube probably did their research and concluded that this case isn't common (and I'd agree with that conclusion :-)) |
Thanks for looking into it @evverx 🙂 |
This issue has been open for 2 weeks so I'm wondering what is holding this back? Due to #1972 I don't have access to the meeting notes (where I assume dashboards would have been mentioned) so I'm kind of in the dark here. As I mentioned elsewhere since the dashboards are great and can be used to view/sort the scorecard output they should also make it possible to cut off the SARIF part of the scorecard action and prevent scorecard alerts from popping up over and over again in the security tab. |
Super happy to see the feedback + iterations here.
I think some of it had to do with the OSS NA conference which multiple maintainers went to. Now that I'm back (and from a personal vacation) I'm ready to see this resolved as well. In terms of adoption, the underlying API the badges currently link to wont be changing, so it's really just a matter of:
For the other @ossf/scorecard-maintainers, the only decision is hosting on the netlify portion of https://securityscorecards.dev/, or keeping it on clomonitor.io? |
+1 I recommend using https://securityscorecards.dev/. It enables larger enterprises to whitelist a single DNS entry, which is a great advantage. |
@spencerschrock got it. Thanks! One last thing. Looking at https://github.com/ossf/scorecard/milestone/5 it seems something called "Structured results" is on its way. As far as I understand the idea is to dump even more json stuff in the foreseeable future. I wonder if it's going to be used by the scorecard action by default? If so it seems it can break the dashboards (because as far as I understand that format isn't expected) and all that json is going to end up in every check and that would bring the UI back to that human-unfriendly format again (unless it's parsed somehow and formatted somehow). |
Without going too much off-topic, I don't see that being an immediate problem.
Changing the JSON output structure is something we're very conservative with, so it will be its own output format (currently gated behind an experimental env flag). If any change to the default scorecard action format were to occur, I would expect a major version change to accompany it.
Our goal is the opposite, to split up the various checks into sub-components so consumers can look at the bits they care about and tune out the noise. But yes it would require a change to dashboards/visualizations at some point in the future. |
I'm not sure why it would be offtopic in an issue where the scorecard UI is discussed. I agree it's not exactly an immediate problem.
I went through those issues and I think the idea is to make it easier for machines (not people) to consume that. The UI that actual maintainers can use has never been discussed there.
It would but it isn't even included in that milestone (or any other milestone for that matter) as far as I can see. |
I'd say both it helps with both, but you're right there was no tracker. #3078
Without any further objections, I think the decision is to donate the static page to https://github.com/ossf/scorecard-webapp. I know we have a directory for static files (link), but I'm not personally familiar with the router/mux we have setup. At the very least it would be accessible at
Are changes made directly to the file, or are there source files which get built into the page? |
I agree and I suspect there're consumers who are probably planning to build some stuff (including all sort of UIs with queries and all kinds of bells and whistles) but my concern was that the UI that maintainers can use wouldn't be a priority. At least until the CLOMonitor folks built those amazing dashboards it was somehow totally acceptable to dump json and call it a day. Time will tell I guess. Anyway I'm not sure what else I can say here so I'd like to thank the CLOMonitor folks once again! |
That sounds great to us! @cynthia-sg and I would be happy to help if there is something to fix on it. And eventually when the JSON output changes we could work with you to support the new format.
Yes, changes are made directly to the file, there is no build process. We've a small fix pending that we'll push on Monday. |
Just a 👍, it is really a downer to press on the badge and get not useful json. If the scorecard is to improve workflows, the badge needs this to make it discoverable/convenient to actually see what to improve (compared to having to use the CLI or so). |
Fantastic. Thanks for the viewer and support!
Sounds good! Do you mind sending the PR to https://github.com/ossf/scorecard-webapp? Dropping it in as |
Related to ossf/scorecard/issues/2979 Signed-off-by: Cintia Sanchez Garcia <[email protected]>
No worries! PR is ready: ossf/scorecard-webapp/pull/406 🙂 |
* Add Scorecard result viewer Related to ossf/scorecard/issues/2979 Signed-off-by: Cintia Sanchez Garcia <[email protected]> * Delete replaceDashes helper Signed-off-by: Cintia Sanchez Garcia <[email protected]> * Use section name from data attribute Signed-off-by: Cintia Sanchez Garcia <[email protected]> --------- Signed-off-by: Cintia Sanchez Garcia <[email protected]>
This has been merged into the site. There may be one or two small tweaks around other supported paths (#ossf/scorecard-webapp#415) before announcing this with the next |
Hi! 👋
This is Sergio from CLOMonitor 🙂
Last week, when we were adding a new check to CLOMonitor for the presence of the OpenSSF Scorecard badge in the repositories' README files, we realized that the badge link points to the Scorecard API result endpoint. We wanted to display that information nicely in CLOMonitor, so we've built a small viewer for the report's json data.
We thought this could be useful outside of CLOMonitor, so instead of adding it as part of the CLOMonitor's UI, we've built it as an independent page that we could donate to you if you'd like. It's just a single self-contained HTML document that can be controlled via some query string parameters. It could serve as a nice badge link destination, for example 😇
You can see it live here. We'll probably tweak a few details over the next couple of days (i.e. some improvements for mobile devices), but it's mostly looking good.
If you'd rather it to continue living only in CLOMonitor for now, please feel free to use the instance we are serving if you'd like, even for the badges 😉 And of course any feedback to improve it is welcomed!
BTW thank you all for the great work done here! Most of CLOMonitor's security checks rely on Scorecard and it has worked great for us ❤️
The text was updated successfully, but these errors were encountered: