Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Return inconclusive result if no fuzzing is detected #1816

Closed
wants to merge 1 commit into from
Closed

✨ Return inconclusive result if no fuzzing is detected #1816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion checks/fuzzing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,5 +86,5 @@ func Fuzzing(c *checker.CheckRequest) checker.CheckResult {
"project is fuzzed in OSS-Fuzz")
}

return checker.CreateMinScoreResult(CheckFuzzing, "project is not fuzzed")
return checker.CreateInconclusiveResult(CheckFuzzing, "could not determine if project is fuzzed")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the message explicit - project not fuzzed through any platforms recognizable by Scorecard: oss-fuzz, CFLite. File a support request [here](https://github.com/ossf/scorecard/issues/897) if you would like support for other fuzzing platforms.. Can even keep this as a failing case instead of inconclusive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to have a generic message File a support request, I think we should do this in a another PR and for all checks. The details has the details on which platforms are not found

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mhh, the details don't have this but it should. Ill update this PR to fix tat too

}
6 changes: 3 additions & 3 deletions docs/checks/internal/checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,9 +374,9 @@ checks:
Risk: `Medium` (possible vulnerabilities in code)

This check tries to determine if the project uses
[fuzzing](https://owasp.org/www-community/Fuzzing) by checking if the repository
name is included in the [OSS-Fuzz](https://github.com/google/oss-fuzz) project
list.
[fuzzing](https://owasp.org/www-community/Fuzzing). The current implementation
check if the repository name is included in the [OSS-Fuzz](https://github.com/google/oss-fuzz) project
list or if [ClusterFuzzLite](https://google.github.io/clusterfuzzlite/) is enabled.

Fuzzing, or fuzz testing, is the practice of feeding unexpected or random data
into a program to expose bugs. Regular fuzzing is important to detect
Expand Down