-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Enable golangci-lint test
presets
#3594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaves some opinionated linters disabled with reasons. Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan and
raghavkaul
as code owners
October 23, 2023 16:56
spencerschrock
temporarily deployed
to
integration-test
October 23, 2023 16:57 — with
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3594 +/- ##
==========================================
- Coverage 76.09% 70.22% -5.88%
==========================================
Files 199 199
Lines 13741 13741
==========================================
- Hits 10456 9649 -807
- Misses 2674 3532 +858
+ Partials 611 560 -51 |
raghavkaul
approved these changes
Oct 27, 2023
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
temporarily deployed
to
integration-test
October 27, 2023 20:12 — with
GitHub Actions
Inactive
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
temporarily deployed
to
integration-test
October 27, 2023 21:53 — with
GitHub Actions
Inactive
diogoteles08
pushed a commit
to diogoteles08/scorecard
that referenced
this pull request
Nov 13, 2023
* enable test preset Leaves some opinionated linters disabled with reasons. Signed-off-by: Spencer Schrock <[email protected]> * fix tparallel issues. Signed-off-by: Spencer Schrock <[email protected]> --------- Signed-off-by: Spencer Schrock <[email protected]> Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
* enable test preset Leaves some opinionated linters disabled with reasons. Signed-off-by: Spencer Schrock <[email protected]> * fix tparallel issues. Signed-off-by: Spencer Schrock <[email protected]> --------- Signed-off-by: Spencer Schrock <[email protected]> Signed-off-by: Allen Shearin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
linter
What is the current behavior?
What is the new behavior (if this is a feature change)?**
disable-all
flag is removed. There's only 6 linters enabled by default (currently) and we have them all enabled already (so no change here):Overall this results in just 1 newly enabled linter:
tparallel
, which flags tests which uset.Parallel
in the parent test, but not the children, or vice-versa. When fixing the errors, I favored parallelizing the tests when possible. For thedependencydiff
tests, I chose to remove thet.Parallel
calls due to the possibility of rate limiting mentioned in #2527Which issue(s) this PR fixes
NONE
Special notes for your reviewer
This approach of enabling the presets and disabling problematic linters is something osv-scanner does, and which I'd like to try. My goal is to auto-pickup new linters whenever we bump our golangci-lint version. That being said, if the reviewer wish to keep the
disable-all
config, I'll change this PR to only enabletparallel
explicitly, not through thetest
preset.Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)