Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 migrate gitlab client import #4452

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

spencerschrock
Copy link
Member

@spencerschrock spencerschrock commented Dec 11, 2024

What kind of change does this PR introduce?

dep update

What is the current behavior?

We used the github.com/xanzy/go-gitlab package.

What is the new behavior (if this is a feature change)?**

The package is deprecated, in favor of the GitLab ran one:
https://gitlab.com/gitlab-org/api/client-go

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Related to #4451

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

Signed-off-by: Spencer Schrock <[email protected]>
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.63%. Comparing base (353ed60) to head (0d1aefb).
Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4452      +/-   ##
==========================================
+ Coverage   66.80%   68.63%   +1.82%     
==========================================
  Files         230      242      +12     
  Lines       16602    18031    +1429     
==========================================
+ Hits        11091    12375    +1284     
- Misses       4808     4848      +40     
- Partials      703      808     +105     

@spencerschrock spencerschrock marked this pull request as ready for review December 11, 2024 22:32
@spencerschrock spencerschrock requested a review from a team as a code owner December 11, 2024 22:32
@spencerschrock spencerschrock requested review from justaugustus and raghavkaul and removed request for a team December 11, 2024 22:32
@justaugustus justaugustus merged commit ec965e2 into ossf:main Dec 12, 2024
42 checks passed
@spencerschrock spencerschrock deleted the gitlab-client branch December 12, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants