-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTC: Fix nack encode seqnum #2766
Conversation
Thank you for submitting. Can you please provide a uTest? This way, we will never encounter any issues with future changes and we can also verify that the modified code is working correctly.
|
Codecov Report
@@ Coverage Diff @@
## 4.0release #2766 +/- ##
==============================================
+ Coverage 60.15% 60.32% +0.16%
==============================================
Files 121 121
Lines 50949 50970 +21
==============================================
+ Hits 30648 30747 +99
+ Misses 20301 20223 -78 | Impacted Files | Coverage Δ | |' Translated to English while maintaining the markdown structure: '| Impacted Files | Coverage Δ | | Continue to review full report at Codecov.
'>
|
trunk/src/utest/srs_utest_rtc.cpp
Outdated
|
||
SrsRtcpNack rtcpNack_encode(ssrc); | ||
for(uint16_t i = 16; i < 50; ++i) { | ||
rtcpNack_encode.add_lost_sn(i); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rtcpNack_encode, rtcpNack_decode, It is better to name them consistently with the style of srs, so change them to rtcp_nack_encode, rtcp_nack_decode would be better.
TRANS_BY_GPT3
No description provided.