Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip device files by default: Use opt.Specials #84

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

otiai10
Copy link
Owner

@otiai10 otiai10 commented Jul 20, 2022

Fix #78

@otiai10
Copy link
Owner Author

otiai10 commented Jul 20, 2022

will fix GoogleContainerTools/kaniko#960

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022

Codecov Report

Merging #84 (ae3e4ab) into main (8575144) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   77.40%   77.65%   +0.25%     
==========================================
  Files          13       13              
  Lines         177      179       +2     
==========================================
+ Hits          137      139       +2     
  Misses         20       20              
  Partials       20       20              
Impacted Files Coverage Δ
options.go 85.71% <ø> (ø)
copy.go 76.00% <100.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8575144...ae3e4ab. Read the comment docs.

@otiai10 otiai10 changed the title Skip device files by default: Use opt.Specials [WIP] Skip device files by default: Use opt.Specials Jul 20, 2022
@ajakk
Copy link

ajakk commented Nov 7, 2022

I'm hitting the aforementioned kaniko issue. Is anything blocking this? Is testing needed?

@otiai10 otiai10 changed the title [WIP] Skip device files by default: Use opt.Specials Skip device files by default: Use opt.Specials Nov 8, 2022
@otiai10
Copy link
Owner Author

otiai10 commented Nov 9, 2022

this is ready. thx

@otiai10 otiai10 merged commit 705b76e into main Nov 9, 2022
@ajakk
Copy link

ajakk commented Nov 9, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to preserve special files
3 participants