-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does the max-diff value gets rounded internally? #82
Comments
Thanks for your report! We found out that max-diff is read as float from the config, but the calculated difference is a double internally. That leads to this rounding error. We'll fix this soonish. |
You’re welcome, thanks for looking into it! |
The fix is included in Release 4.3.4 - your problem should hopefully be solved. |
Thanks a lot! Just updated to the new version, I will keep an eye on it and, if there still is a problem, reopen that issue here :) |
I have a comparision with a very small difference value (
0.00036101398601399
). When I use exactly that value for themax-diff
config value, the check fails. Increasing it to something like0.00037101398601399
works, so I wondered if there is some rounding done internally?The text was updated successfully, but these errors were encountered: