treat forward slash as a pathspec and truncate biheight in wing to an… #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… int16
fixes #1137
It uses a forward slash in the path for getprivateprofilestring which causes it to not be able to find it's ini file properly. It also fails to sign extend to a long it's top down bitmap height so it's a negative short in a long var. Wing.dll on win31 uses createcompatiblebitmap which takes an int16 for height so there are unlikely to be any compatibility issues (on win95 and ntvdm it uses createdibsection which is the problem here, I can't imagine there are any win16 wing programs that only work on win95). Amusingly the readme.txt says that it might not work on win95 which would have been trivial for them to fix.