Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing a custom initial device display name #183

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

ouchadam
Copy link
Owner

@ouchadam ouchadam commented Oct 2, 2022

Fixes #172

  • Uses SmallTalk Android with a 4 character random

2022-10-02T17:03:29,221462771+01:00

- Uses SmallTalk Android with a 4 character random
@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Merging #183 (b06f6b4) into main (d74db39) will increase coverage by 0.04%.
The diff coverage is 68.75%.

@@             Coverage Diff              @@
##               main     #183      +/-   ##
============================================
+ Coverage     62.07%   62.11%   +0.04%     
  Complexity      528      528              
============================================
  Files           211      211              
  Lines          5149     5155       +6     
  Branches        618      618              
============================================
+ Hits           3196     3202       +6     
- Misses         1662     1663       +1     
+ Partials        291      290       -1     
Impacted Files Coverage Δ
app/src/main/kotlin/app/dapk/st/graph/AppModule.kt 0.00% <0.00%> (ø)
...uth/internal/LoginWithUserPasswordServerUseCase.kt 23.52% <50.00%> (+4.77%) ⬆️
...main/kotlin/app/dapk/st/matrix/auth/AuthService.kt 90.00% <100.00%> (+35.45%) ⬆️
...in/app/dapk/st/matrix/auth/internal/AuthRequest.kt 90.56% <100.00%> (+0.18%) ⬆️
...dapk/st/matrix/auth/internal/DefaultAuthService.kt 72.72% <100.00%> (ø)
...trix/auth/internal/LoginWithUserPasswordUseCase.kt 75.67% <100.00%> (+0.67%) ⬆️
.../olm/src/main/kotlin/app/dapk/st/olm/OlmWrapper.kt 88.88% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2022

APK Size: 1.9 MB

@ouchadam ouchadam merged commit ea26250 into main Oct 2, 2022
@ouchadam ouchadam deleted the feature/device-display-name branch October 2, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the Session Name more identifiable
1 participant