Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes login sometimes never transitioning to next state #207

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

ouchadam
Copy link
Owner

@ouchadam ouchadam commented Oct 17, 2022

The ViewModelScope was being cancelled with the Composable lifecycle which put the ViewModel in an invalid state which ignored future interactions, causing an infinite spinner

BEFORE AFTER
before-login after-login

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #207 (b8b1612) into main (8270681) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #207      +/-   ##
============================================
+ Coverage     57.97%   57.98%   +0.01%     
  Complexity      520      520              
============================================
  Files           223      223              
  Lines          5611     5610       -1     
  Branches        639      639              
============================================
  Hits           3253     3253              
+ Misses         2072     2071       -1     
  Partials        286      286              
Impacted Files Coverage Δ
.../src/main/kotlin/app/dapk/st/home/HomeViewModel.kt 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

APK Size: 1.92 MB

@ouchadam ouchadam merged commit 0d9bb30 into main Oct 17, 2022
@ouchadam ouchadam deleted the bug/login-never-completes branch October 17, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant