Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech/sync error logging #262

Merged
merged 4 commits into from
Nov 11, 2022
Merged

Tech/sync error logging #262

merged 4 commits into from
Nov 11, 2022

Conversation

ouchadam
Copy link
Owner

@ouchadam ouchadam commented Nov 10, 2022 •
edited
Loading

  • Including sync errors into the event log and crashlytics tracking (if the build has it included)
  • Allows the Messages screen to load an empty view when the sync fails (which in turn allows the logs to be enabled and checked)

*Forcing the sync response parsing to fail
Screenshot_20221110_231439

@ouchadam
tracking and logging locally sync errors
b8f60d8
@ouchadam
allowing the messages view to fail with nothing to see here
d66f0c0 
- means the user can go into the settings and enable logging to find out what's going wrong
@ouchadam
logging inner error cause to the log output
0020c29 
- also fixes log lines introducing blank lines due to a missing line height
@ouchadam
reverting unused error emissions
f498840
@github-actions
Copy link
Contributor

APK Size: 2.01 MB

@ouchadam ouchadam merged commit 956d50d into main Nov 11, 2022
@ouchadam ouchadam deleted the tech/sync-error-logging branch November 11, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ouchadam