Assignment #4 - Basic authentication

[hussainanjar]

Closes #118

[FennNaten]

Hi,
I can see that you have the same failing test issue that I had. I don't want to spoil the fun of bug hunting, so I won't write the solution here, but if you're stuck and want help at some point, you can ask ;)
Also, sorry for the reference to your Pull Request that I made, I wanted to link the issue but failed to select the correct item in the suggestions -_-

[hussainanjar]

@FennNaten help 😸

[FennNaten]

^^ Just look at my latest commit on pr #121 ;) if you copy/pasted version.js as I did for private.js base, your next() call is not in the right place. You should move it into the callback of register(basic), otherwise it's called too soon ;)

[AdriVanHoudt]

why not just pass the user object? Now you'll have to access it via request.auth.credentials.user instead of request.auth.credentials

[hussainanjar]

Naturally it feels like like passing object is more useful, for instance if the user object had firstName and lastName or roles, i would get them with the object.

[hueniverse]

I agree with @AdriVanHoudt. The user key doesn't add much here.